maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Using the integrated assembler we'd fail to change section to the 

.tbss section for zerofill thread locals. Make sure we do this
before emitting the zerofills.

Fixes PR15972.

llvm-svn: 187913
This commit is contained in:
Eric Christopher 2013-08-07 21:13:06 +00:00
parent 42ae459174
commit 7af8baf678
2 changed files with 36 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
View File

@ -368,9 +368,10 @@ void AsmPrinter::EmitGlobalVariable(const GlobalVariable *GV) {
MCSymbol *MangSym =
OutContext.GetOrCreateSymbol(GVSym->getName() + Twine("$tlv$init"));
if (GVKind.isThreadBSS())
if (GVKind.isThreadBSS()) {
TheSection = getObjFileLowering().getTLSBSSSection();
OutStreamer.EmitTBSSSymbol(TheSection, MangSym, Size, 1 << AlignLog);
else if (GVKind.isThreadData()) {
} else if (GVKind.isThreadData()) {
OutStreamer.SwitchSection(TheSection);
EmitAlignment(AlignLog, GV);

33
llvm/test/MC/MachO/tlv-bss.ll Normal file
View File

@ -0,0 +1,33 @@
; RUN: llc -O0 -mtriple=x86_64-apple-darwin12 -filetype=obj -o - %s | macho-dump | FileCheck %s
; Test that we emit weak_odr thread_locals correctly into the thread_bss section
; PR15972
; CHECK: __thread_bss
; CHECK: 'size', 8
; CHECK: 'alignment', 3
; CHECK: __thread_vars
; Generated from this C++ source
; template<class T>
; struct Tls {
; static __thread void* val;
; };
; template<class T> __thread void* Tls<T>::val;
; void* f(int x) {
; return Tls<long>::val;
; }
@_ZN3TlsIlE3valE = weak_odr thread_local global i8* null, align 8
; Function Attrs: nounwind ssp uwtable
define i8* @_Z1fi(i32 %x) #0 {
entry:
%x.addr = alloca i32, align 4
store i32 %x, i32* %x.addr, align 4
%0 = load i8** @_ZN3TlsIlE3valE, align 8
ret i8* %0
}
attributes #0 = { nounwind ssp uwtable "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf"="true" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }