maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix a bunch of [-Werror,-Winconsistent-missing-override] errors. 

llvm-svn: 221231
This commit is contained in:
Eric Christopher 2014-11-04 03:13:17 +00:00
parent 5b95b72bb7
commit 7ab81b9149
5 changed files with 117 additions and 116 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
lldb/source/Plugins/Platform/Kalimba/PlatformKalimba.h
View File

@ -46,10 +46,10 @@ namespace lldb_private {
GetPluginDescriptionStatic (bool is_host);
virtual lldb_private::ConstString
GetPluginName();
GetPluginName() override;
virtual uint32_t
GetPluginVersion()
GetPluginVersion() override
{
return 1;
}
@ -61,47 +61,47 @@ namespace lldb_private {
ResolveExecutable (const FileSpec &exe_file,
const ArchSpec &arch,
lldb::ModuleSP &module_sp,
const FileSpecList *module_search_paths_ptr);
const FileSpecList *module_search_paths_ptr) override;
virtual const char *
GetDescription ()
GetDescription () override
{
return GetPluginDescriptionStatic(IsHost());
}
virtual void
GetStatus (Stream &strm);
GetStatus (Stream &strm) override;
virtual Error
GetFileWithUUID (const FileSpec &platform_file,
const UUID* uuid, FileSpec &local_file);
const UUID* uuid, FileSpec &local_file) override;
virtual bool
GetProcessInfo (lldb::pid_t pid, ProcessInstanceInfo &proc_info);
GetProcessInfo (lldb::pid_t pid, ProcessInstanceInfo &proc_info) override;
virtual bool
GetSupportedArchitectureAtIndex (uint32_t idx, ArchSpec &arch);
GetSupportedArchitectureAtIndex (uint32_t idx, ArchSpec &arch) override;
virtual size_t
GetSoftwareBreakpointTrapOpcode (Target &target,
BreakpointSite *bp_site);
BreakpointSite *bp_site) override;
virtual lldb_private::Error
LaunchProcess (lldb_private::ProcessLaunchInfo &launch_info);
LaunchProcess (lldb_private::ProcessLaunchInfo &launch_info) override;
virtual lldb::ProcessSP
Attach(ProcessAttachInfo &attach_info, Debugger &debugger,
Target *target, Listener &listener, Error &error);
Target *target, Listener &listener, Error &error) override;
// Kalimba processes can not be launched by spawning and attaching.
virtual bool
CanDebugProcess ()
CanDebugProcess () override
{
return false;
}
virtual void
CalculateTrapHandlerSymbolNames ();
CalculateTrapHandlerSymbolNames () override;
Error
LaunchNativeProcess (

43
lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.h
View File

@ -31,8 +31,9 @@ public:
//------------------------------------------------------------
// lldb_private::Platform functions
//------------------------------------------------------------
virtual lldb_private::OptionGroupOptions*
GetConnectionOptions (lldb_private::CommandInterpreter& interpreter);
virtual lldb_private::OptionGroupOptions
*GetConnectionOptions(
lldb_private::CommandInterpreter &interpreter) override;
const char *
GetHostname () override;
@ -47,47 +48,47 @@ public:
PutFile (const lldb_private::FileSpec& source,
const lldb_private::FileSpec& destination,
uint32_t uid = UINT32_MAX,
uint32_t gid = UINT32_MAX);
uint32_t gid = UINT32_MAX) override;
virtual lldb::user_id_t
OpenFile (const lldb_private::FileSpec& file_spec,
uint32_t flags,
uint32_t mode,
lldb_private::Error &error);
lldb_private::Error &error) override;
virtual bool
CloseFile (lldb::user_id_t fd,
lldb_private::Error &error);
lldb_private::Error &error) override;
virtual uint64_t
ReadFile (lldb::user_id_t fd,
uint64_t offset,
void *dst,
uint64_t dst_len,
lldb_private::Error &error);
lldb_private::Error &error) override;
virtual uint64_t
WriteFile (lldb::user_id_t fd,
uint64_t offset,
const void* src,
uint64_t src_len,
lldb_private::Error &error);
lldb_private::Error &error) override;
virtual lldb::user_id_t
GetFileSize (const lldb_private::FileSpec& file_spec);
GetFileSize (const lldb_private::FileSpec& file_spec) override;
virtual lldb_private::Error
CreateSymlink(const char *src, const char *dst);
CreateSymlink(const char *src, const char *dst) override;
virtual lldb_private::Error
GetFile (const lldb_private::FileSpec& source,
const lldb_private::FileSpec& destination);
const lldb_private::FileSpec& destination) override;
virtual lldb_private::ConstString
GetRemoteWorkingDirectory();
GetRemoteWorkingDirectory() override;
virtual bool
SetRemoteWorkingDirectory(const lldb_private::ConstString &path);
SetRemoteWorkingDirectory(const lldb_private::ConstString &path) override;
bool
GetRemoteOSVersion () override;
@ -113,22 +114,22 @@ public:
int *status_ptr, // Pass NULL if you don't want the process exit status
int *signo_ptr, // Pass NULL if you don't want the signal that caused the process to exit
std::string *command_output, // Pass NULL if you don't want the command output
uint32_t timeout_sec); // Timeout in seconds to wait for shell program to finish
uint32_t timeout_sec) override;// Timeout in seconds to wait for shell program to finish
virtual lldb_private::Error
MakeDirectory (const char *path, uint32_t mode);
MakeDirectory (const char *path, uint32_t mode) override;
virtual lldb_private::Error
GetFilePermissions (const char *path, uint32_t &file_permissions);
GetFilePermissions (const char *path, uint32_t &file_permissions) override;
virtual lldb_private::Error
SetFilePermissions (const char *path, uint32_t file_permissions);
SetFilePermissions (const char *path, uint32_t file_permissions) override;
virtual bool
GetFileExists (const lldb_private::FileSpec& file_spec);
GetFileExists (const lldb_private::FileSpec& file_spec) override;
virtual lldb_private::Error
Unlink (const char *path);
Unlink (const char *path) override;
lldb_private::Error
LaunchProcess (lldb_private::ProcessLaunchInfo &launch_info) override;
@ -148,15 +149,15 @@ public:
lldb_private::Error &error) override;
virtual std::string
GetPlatformSpecificConnectionInformation();
GetPlatformSpecificConnectionInformation() override;
virtual bool
CalculateMD5 (const lldb_private::FileSpec& file_spec,
uint64_t &low,
uint64_t &high);
uint64_t &high) override;
virtual void
CalculateTrapHandlerSymbolNames ();
CalculateTrapHandlerSymbolNames () override;
lldb_private::Error
ConnectRemote (lldb_private::Args& args) override;

56
lldb/source/Plugins/Process/POSIX/ProcessPOSIX.h
View File

@ -42,104 +42,104 @@ public:
// Process protocol.
//------------------------------------------------------------------
virtual void
Finalize();
Finalize() override;
virtual bool
CanDebug(lldb_private::Target &target, bool plugin_specified_by_name);
CanDebug(lldb_private::Target &target, bool plugin_specified_by_name) override;
virtual lldb_private::Error
WillLaunch(lldb_private::Module *module);
WillLaunch(lldb_private::Module *module) override;
virtual lldb_private::Error
DoAttachToProcessWithID(lldb::pid_t pid);
DoAttachToProcessWithID(lldb::pid_t pid) override;
virtual lldb_private::Error
DoAttachToProcessWithID (lldb::pid_t pid, const lldb_private::ProcessAttachInfo &attach_info);
DoAttachToProcessWithID (lldb::pid_t pid, const lldb_private::ProcessAttachInfo &attach_info) override;
virtual lldb_private::Error
DoLaunch (lldb_private::Module *exe_module,
lldb_private::ProcessLaunchInfo &launch_info);
lldb_private::ProcessLaunchInfo &launch_info) override;
virtual void
DidLaunch();
DidLaunch() override;
virtual lldb_private::Error
DoResume();
DoResume() override;
virtual lldb_private::Error
DoHalt(bool &caused_stop);
DoHalt(bool &caused_stop) override;
virtual lldb_private::Error
DoDetach(bool keep_stopped) = 0;
DoDetach(bool keep_stopped) override = 0;
virtual lldb_private::Error
DoSignal(int signal);
DoSignal(int signal) override;
virtual lldb_private::Error
DoDestroy();
DoDestroy() override;
virtual void
DoDidExec();
DoDidExec() override;
virtual void
RefreshStateAfterStop();
RefreshStateAfterStop() override;
virtual bool
IsAlive();
IsAlive() override;
virtual size_t
DoReadMemory(lldb::addr_t vm_addr,
void *buf,
size_t size,
lldb_private::Error &error);
lldb_private::Error &error) override;
virtual size_t
DoWriteMemory(lldb::addr_t vm_addr, const void *buf, size_t size,
lldb_private::Error &error);
lldb_private::Error &error) override;
virtual lldb::addr_t
DoAllocateMemory(size_t size, uint32_t permissions,
lldb_private::Error &error);
lldb_private::Error &error) override;
virtual lldb_private::Error
DoDeallocateMemory(lldb::addr_t ptr);
DoDeallocateMemory(lldb::addr_t ptr) override;
virtual size_t
GetSoftwareBreakpointTrapOpcode(lldb_private::BreakpointSite* bp_site);
virtual lldb_private::Error
EnableBreakpointSite(lldb_private::BreakpointSite *bp_site);
EnableBreakpointSite(lldb_private::BreakpointSite *bp_site) override;
virtual lldb_private::Error
DisableBreakpointSite(lldb_private::BreakpointSite *bp_site);
DisableBreakpointSite(lldb_private::BreakpointSite *bp_site) override;
virtual lldb_private::Error
EnableWatchpoint(lldb_private::Watchpoint *wp, bool notify = true);
EnableWatchpoint(lldb_private::Watchpoint *wp, bool notify = true) override;
virtual lldb_private::Error
DisableWatchpoint(lldb_private::Watchpoint *wp, bool notify = true);
DisableWatchpoint(lldb_private::Watchpoint *wp, bool notify = true) override;
virtual lldb_private::Error
GetWatchpointSupportInfo(uint32_t &num);
GetWatchpointSupportInfo(uint32_t &num) override;
virtual lldb_private::Error
GetWatchpointSupportInfo(uint32_t &num, bool &after);
GetWatchpointSupportInfo(uint32_t &num, bool &after) override;
virtual uint32_t
UpdateThreadListIfNeeded();
virtual bool
UpdateThreadList(lldb_private::ThreadList &old_thread_list,
lldb_private::ThreadList &new_thread_list) = 0;
lldb_private::ThreadList &new_thread_list) override = 0;
virtual lldb::ByteOrder
GetByteOrder() const;
virtual lldb::addr_t
GetImageInfoAddress();
GetImageInfoAddress() override;
virtual size_t
PutSTDIN(const char *buf, size_t len, lldb_private::Error &error);
PutSTDIN(const char *buf, size_t len, lldb_private::Error &error) override;
const lldb::DataBufferSP
GetAuxvData () override;

24
lldb/source/Plugins/Process/elf-core/ProcessElfCore.h
View File

@ -68,52 +68,52 @@ public:
//------------------------------------------------------------------
virtual bool
CanDebug (lldb_private::Target &target,
bool plugin_specified_by_name);
bool plugin_specified_by_name) override;
//------------------------------------------------------------------
// Creating a new process, or attaching to an existing one
//------------------------------------------------------------------
virtual lldb_private::Error
DoLoadCore ();
DoLoadCore () override;
virtual lldb_private::DynamicLoader *
GetDynamicLoader ();
GetDynamicLoader () override;
//------------------------------------------------------------------
// PluginInterface protocol
//------------------------------------------------------------------
virtual lldb_private::ConstString
GetPluginName();
GetPluginName() override;
virtual uint32_t
GetPluginVersion();
GetPluginVersion() override;
//------------------------------------------------------------------
// Process Control
//------------------------------------------------------------------
virtual lldb_private::Error
DoDestroy ();
DoDestroy () override;
virtual void
RefreshStateAfterStop();
RefreshStateAfterStop() override;
//------------------------------------------------------------------
// Process Queries
//------------------------------------------------------------------
virtual bool
IsAlive ();
IsAlive () override;
//------------------------------------------------------------------
// Process Memory
//------------------------------------------------------------------
virtual size_t
ReadMemory (lldb::addr_t addr, void *buf, size_t size, lldb_private::Error &error);
ReadMemory (lldb::addr_t addr, void *buf, size_t size, lldb_private::Error &error) override;
virtual size_t
DoReadMemory (lldb::addr_t addr, void *buf, size_t size, lldb_private::Error &error);
DoReadMemory (lldb::addr_t addr, void *buf, size_t size, lldb_private::Error &error) override;
virtual lldb::addr_t
GetImageInfoAddress ();
GetImageInfoAddress () override;
lldb_private::ArchSpec
GetArchitecture();
@ -128,7 +128,7 @@ protected:
virtual bool
UpdateThreadList (lldb_private::ThreadList &old_thread_list,
lldb_private::ThreadList &new_thread_list);
lldb_private::ThreadList &new_thread_list) override;
private:
//------------------------------------------------------------------

84
lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
View File

@ -75,148 +75,148 @@ public:
//------------------------------------------------------------------
virtual bool
CanDebug (lldb_private::Target &target,
bool plugin_specified_by_name);
bool plugin_specified_by_name) override;
virtual lldb_private::CommandObject *
GetPluginCommandObject();
GetPluginCommandObject() override;
//------------------------------------------------------------------
// Creating a new process, or attaching to an existing one
//------------------------------------------------------------------
virtual lldb_private::Error
WillLaunch (lldb_private::Module* module);
WillLaunch (lldb_private::Module* module) override;
virtual lldb_private::Error
DoLaunch (lldb_private::Module *exe_module,
lldb_private::ProcessLaunchInfo &launch_info);
lldb_private::ProcessLaunchInfo &launch_info) override;
virtual void
DidLaunch ();
DidLaunch () override;
virtual lldb_private::Error
WillAttachToProcessWithID (lldb::pid_t pid);
WillAttachToProcessWithID (lldb::pid_t pid) override;
virtual lldb_private::Error
WillAttachToProcessWithName (const char *process_name, bool wait_for_launch);
WillAttachToProcessWithName (const char *process_name, bool wait_for_launch) override;
virtual lldb_private::Error
DoConnectRemote (lldb_private::Stream *strm, const char *remote_url);
DoConnectRemote (lldb_private::Stream *strm, const char *remote_url) override;
lldb_private::Error
WillLaunchOrAttach ();
virtual lldb_private::Error
DoAttachToProcessWithID (lldb::pid_t pid);
DoAttachToProcessWithID (lldb::pid_t pid) override;
virtual lldb_private::Error
DoAttachToProcessWithID (lldb::pid_t pid, const lldb_private::ProcessAttachInfo &attach_info);
DoAttachToProcessWithID (lldb::pid_t pid, const lldb_private::ProcessAttachInfo &attach_info) override;
virtual lldb_private::Error
DoAttachToProcessWithName (const char *process_name,
const lldb_private::ProcessAttachInfo &attach_info);
const lldb_private::ProcessAttachInfo &attach_info) override;
virtual void
DidAttach (lldb_private::ArchSpec &process_arch);
DidAttach (lldb_private::ArchSpec &process_arch) override;
//------------------------------------------------------------------
// PluginInterface protocol
//------------------------------------------------------------------
virtual lldb_private::ConstString
GetPluginName();
GetPluginName() override;
virtual uint32_t
GetPluginVersion();
GetPluginVersion() override;
//------------------------------------------------------------------
// Process Control
//------------------------------------------------------------------
virtual lldb_private::Error
WillResume ();
WillResume () override;
virtual lldb_private::Error
DoResume ();
DoResume () override;
virtual lldb_private::Error
DoHalt (bool &caused_stop);
DoHalt (bool &caused_stop) override;
virtual lldb_private::Error
DoDetach (bool keep_stopped);
DoDetach (bool keep_stopped) override;
virtual bool
DetachRequiresHalt() { return true; }
DetachRequiresHalt() override { return true; }
virtual lldb_private::Error
DoSignal (int signal);
DoSignal (int signal) override;
virtual lldb_private::Error
DoDestroy ();
DoDestroy () override;
virtual void
RefreshStateAfterStop();
RefreshStateAfterStop() override;
//------------------------------------------------------------------
// Process Queries
//------------------------------------------------------------------
virtual bool
IsAlive ();
IsAlive () override;
virtual lldb::addr_t
GetImageInfoAddress();
GetImageInfoAddress() override;
//------------------------------------------------------------------
// Process Memory
//------------------------------------------------------------------
virtual size_t
DoReadMemory (lldb::addr_t addr, void *buf, size_t size, lldb_private::Error &error);
DoReadMemory (lldb::addr_t addr, void *buf, size_t size, lldb_private::Error &error) override;
virtual size_t
DoWriteMemory (lldb::addr_t addr, const void *buf, size_t size, lldb_private::Error &error);
DoWriteMemory (lldb::addr_t addr, const void *buf, size_t size, lldb_private::Error &error) override;
virtual lldb::addr_t
DoAllocateMemory (size_t size, uint32_t permissions, lldb_private::Error &error);
DoAllocateMemory (size_t size, uint32_t permissions, lldb_private::Error &error) override;
virtual lldb_private::Error
GetMemoryRegionInfo (lldb::addr_t load_addr,
lldb_private::MemoryRegionInfo &region_info);
lldb_private::MemoryRegionInfo &region_info) override;
virtual lldb_private::Error
DoDeallocateMemory (lldb::addr_t ptr);
DoDeallocateMemory (lldb::addr_t ptr) override;
//------------------------------------------------------------------
// Process STDIO
//------------------------------------------------------------------
virtual size_t
PutSTDIN (const char *buf, size_t buf_size, lldb_private::Error &error);
PutSTDIN (const char *buf, size_t buf_size, lldb_private::Error &error) override;
//----------------------------------------------------------------------
// Process Breakpoints
//----------------------------------------------------------------------
virtual lldb_private::Error
EnableBreakpointSite (lldb_private::BreakpointSite *bp_site);
EnableBreakpointSite (lldb_private::BreakpointSite *bp_site) override;
virtual lldb_private::Error
DisableBreakpointSite (lldb_private::BreakpointSite *bp_site);
DisableBreakpointSite (lldb_private::BreakpointSite *bp_site) override;
//----------------------------------------------------------------------
// Process Watchpoints
//----------------------------------------------------------------------
virtual lldb_private::Error
EnableWatchpoint (lldb_private::Watchpoint *wp, bool notify = true);
EnableWatchpoint (lldb_private::Watchpoint *wp, bool notify = true) override;
virtual lldb_private::Error
DisableWatchpoint (lldb_private::Watchpoint *wp, bool notify = true);
DisableWatchpoint (lldb_private::Watchpoint *wp, bool notify = true) override;
virtual lldb_private::Error
GetWatchpointSupportInfo (uint32_t &num);
GetWatchpointSupportInfo (uint32_t &num) override;
virtual lldb_private::Error
GetWatchpointSupportInfo (uint32_t &num, bool& after);
GetWatchpointSupportInfo (uint32_t &num, bool& after) override;
virtual bool
StartNoticingNewThreads();
StartNoticingNewThreads() override;
virtual bool
StopNoticingNewThreads();
StopNoticingNewThreads() override;
GDBRemoteCommunicationClient &
GetGDBRemote()
@ -225,13 +225,13 @@ public:
}
virtual lldb_private::Error
SendEventData(const char *data);
SendEventData(const char *data) override;
//----------------------------------------------------------------------
// Override SetExitStatus so we can disconnect from the remote GDB server
//----------------------------------------------------------------------
virtual bool
SetExitStatus (int exit_status, const char *cstr);
SetExitStatus (int exit_status, const char *cstr) override;
void
SetUserSpecifiedMaxMemoryTransferSize (uint64_t user_specified_max);
@ -287,7 +287,7 @@ protected:
virtual bool
UpdateThreadList (lldb_private::ThreadList &old_thread_list,
lldb_private::ThreadList &new_thread_list);
lldb_private::ThreadList &new_thread_list) override;
lldb_private::Error
LaunchAndConnectToDebugserver (const lldb_private::ProcessInfo &process_info);
@ -388,7 +388,7 @@ protected:
std::string &dispatch_queue_name);
lldb_private::DynamicLoader *
GetDynamicLoader ();
GetDynamicLoader () override;
private:
//------------------------------------------------------------------