From 7a28a7fbd893413678ad70a92696a78147de7b82 Mon Sep 17 00:00:00 2001 From: Xinliang David Li Date: Sat, 3 Sep 2016 22:26:11 +0000 Subject: [PATCH] Cleanup : Use metadata preserving API for branch creation Use the wrapper API in IRBuilder that does meta data copy to create new branch in LoopUnswitch. llvm-svn: 280602 --- llvm/lib/Transforms/Scalar/LoopUnswitch.cpp | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp b/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp index d419e7238606..6c1f9c4a1036 100644 --- a/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp +++ b/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp @@ -763,15 +763,10 @@ void LoopUnswitch::EmitPreheaderBranchOnCondition(Value *LIC, Constant *Val, } // Insert the new branch. - BranchInst *BI = BranchInst::Create(TrueDest, FalseDest, BranchVal, InsertPt); - if (TI) { - // FIXME: check why white list is needed here: - unsigned WL[3] = {LLVMContext::MD_dbg, LLVMContext::MD_prof, - LLVMContext::MD_make_implicit}; - BI->copyMetadata(*TI, makeArrayRef(&WL[0], 3)); - if (Swapped) - BI->swapProfMetadata(); - } + BranchInst *BI = + IRBuilder<>(InsertPt).CreateCondBr(BranchVal, TrueDest, FalseDest, TI); + if (Swapped) + BI->swapProfMetadata(); // If either edge is critical, split it. This helps preserve LoopSimplify // form for enclosing loops.