maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

AMDGPU: Verify that SOP2/SOPC instructions have at most one immediate operand 

Summary:
No test case because I don't know of a way to trigger this, but I
accidentally caused this to fail while working on a different change.

Change-Id: I8015aa447fe27163cc4e4902205a203bd44bf7e3

Reviewers: arsenm, rampitec

Subscribers: kzhuravl, jvesely, wdng, yaxunl, dstuttard, tpr, t-tye, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D61490

llvm-svn: 360123
This commit is contained in:
Nicolai Haehnle 2019-05-07 09:19:09 +00:00
parent fdbb61856e
commit 79ea85c6af
2 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
View File

@ -3191,6 +3191,24 @@ bool SIInstrInfo::verifyInstruction(const MachineInstr &MI,
}
}
if (isSOP2(MI) || isSOPC(MI)) {
const MachineOperand &Src0 = MI.getOperand(Src0Idx);
const MachineOperand &Src1 = MI.getOperand(Src1Idx);
unsigned Immediates = 0;
if (!Src0.isReg() &&
!isInlineConstant(Src0, Desc.OpInfo[Src0Idx].OperandType))
Immediates++;
if (!Src1.isReg() &&
!isInlineConstant(Src1, Desc.OpInfo[Src1Idx].OperandType))
Immediates++;
if (Immediates > 1) {
ErrInfo = "SOP2/SOPC instruction requires too many immediate constants";
return false;
}
}
if (isSOPK(MI)) {
auto Op = getNamedOperand(MI, AMDGPU::OpName::simm16);
if (Desc.isBranch()) {

21
llvm/test/CodeGen/AMDGPU/verify-sop.mir Normal file
View File

@ -0,0 +1,21 @@
# RUN: not llc -march=amdgcn -run-pass machineverifier %s -o - 2>&1 | FileCheck %s
# CHECK: *** Bad machine code: SOP2/SOPC instruction requires too many immediate constants
# CHECK: - instruction: %0:sreg_32_xm0 = S_ADD_I32
# CHECK: *** Bad machine code: SOP2/SOPC instruction requires too many immediate constants
# CHECK: - instruction: S_CMP_EQ_U32
# CHECK-NOT: Bad machine code
---
name: sop2_sopc
tracksRegLiveness: true
body: |
bb.0:
%0:sreg_32_xm0 = S_ADD_I32 2011, -113, implicit-def $scc
S_CMP_EQ_U32 2011, -113, implicit-def $scc
%1:sreg_32_xm0 = S_SUB_I32 2011, 10, implicit-def $scc
S_CMP_LG_U32 -5, 2011, implicit-def $scc
...