maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[MLIR][Presburger] Simplify checkExplicitRepresentation 

This also gets rid of a clang-tidy warning.

Reviewed By: Groverkss

Differential Revision: https://reviews.llvm.org/D118780
This commit is contained in:
Arjun P 2022-02-02 19:02:34 +05:30
parent d079995dd0
commit 79728453b7
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
mlir/lib/Analysis/Presburger/Utils.cpp
View File

@ -184,23 +184,23 @@ static LogicalResult getDivRepr(const IntegerPolyhedron &cst, unsigned pos,
// explicit representation has not been found yet, otherwise returns `true`.
static bool checkExplicitRepresentation(const IntegerPolyhedron &cst,
ArrayRef<bool> foundRepr,
SmallVectorImpl<int64_t> &dividend,
ArrayRef<int64_t> dividend,
unsigned pos) {
// Exit to avoid circular dependencies between divisions.
unsigned c, f;
for (c = 0, f = cst.getNumIds(); c < f; ++c) {
for (unsigned c = 0, e = cst.getNumIds(); c < e; ++c) {
if (c == pos)
continue;
if (!foundRepr[c] && dividend[c] != 0)
break;
if (!foundRepr[c] && dividend[c] != 0) {
// Expression can't be constructed as it depends on a yet unknown
// identifier.
//
// TODO: Visit/compute the identifiers in an order so that this doesn't
// happen. More complex but much more efficient.
return false;
}
}
// Expression can't be constructed as it depends on a yet unknown
// identifier.
// TODO: Visit/compute the identifiers in an order so that this doesn't
// happen. More complex but much more efficient.
if (c < f)
return false;
return true;
}