From 79114a673e65fc03626da592a843f3e7c4794d78 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Wed, 11 Jan 2017 15:13:05 +0000 Subject: [PATCH] Make the -b binary .data section rw. This matches what bfd and gold do. It also matches the common flags of other .data sections. llvm-svn: 291674 --- lld/ELF/InputFiles.cpp | 4 ++-- lld/test/ELF/format-binary.test | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lld/ELF/InputFiles.cpp b/lld/ELF/InputFiles.cpp index 1fddf40f5b22..f3afb1c34562 100644 --- a/lld/ELF/InputFiles.cpp +++ b/lld/ELF/InputFiles.cpp @@ -857,8 +857,8 @@ template void BinaryFile::parse() { StringRef EndName = Saver.save(Twine(Filename) + "_end"); StringRef SizeName = Saver.save(Twine(Filename) + "_size"); - auto *Section = - make>(SHF_ALLOC, SHT_PROGBITS, 8, Data, ".data"); + auto *Section = make>(SHF_ALLOC | SHF_WRITE, SHT_PROGBITS, + 8, Data, ".data"); Sections.push_back(Section); elf::Symtab::X->addRegular(StartName, STV_DEFAULT, STT_OBJECT, 0, 0, diff --git a/lld/test/ELF/format-binary.test b/lld/test/ELF/format-binary.test index 586f5f963dfa..94b9b51afe78 100644 --- a/lld/test/ELF/format-binary.test +++ b/lld/test/ELF/format-binary.test @@ -15,6 +15,7 @@ # CHECK-NEXT: Type: SHT_PROGBITS # CHECK-NEXT: Flags [ # CHECK-NEXT: SHF_ALLOC +# CHECK-NEXT: SHF_WRITE # CHECK-NEXT: ] # CHECK-NEXT: Address: 0x0 # CHECK-NEXT: Offset: