maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Renaming a bulk of method calls from Get() to something more descriptive 

llvm-svn: 139435
This commit is contained in:
Enrico Granata 2011-09-09 23:33:14 +00:00
parent b1d7529e57
commit 78d0638b7d
5 changed files with 26 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/include/lldb/Core/DataVisualization.h
View File

@ -49,7 +49,7 @@ public:
{ {
public: public:
static lldb::ValueFormatSP static lldb::ValueFormatSP
Get (ValueObject& valobj, lldb::DynamicValueType use_dynamic); GetFormat (ValueObject& valobj, lldb::DynamicValueType use_dynamic);
static void static void
Add (const ConstString &type, const lldb::ValueFormatSP &entry); Add (const ConstString &type, const lldb::ValueFormatSP &entry);
@ -86,7 +86,7 @@ public:
{ {
public: public:
static bool static bool
Get (const ConstString &type, lldb::SummaryFormatSP &entry); GetSummaryFormat (const ConstString &type, lldb::SummaryFormatSP &entry);
static void static void
Add (const ConstString &type, const lldb::SummaryFormatSP &entry); Add (const ConstString &type, const lldb::SummaryFormatSP &entry);
@ -109,7 +109,7 @@ public:
public: public:
static bool static bool
Get (const ConstString &category, lldb::FormatCategorySP &entry); GetCategory (const ConstString &category, lldb::FormatCategorySP &entry);
static void static void
Add (const ConstString &category); Add (const ConstString &category);

2
lldb/source/Commands/CommandObjectFrame.cpp
View File

@ -394,7 +394,7 @@ public:
SummaryFormatSP summary_format_sp; SummaryFormatSP summary_format_sp;
if (!m_option_variable.summary.empty()) if (!m_option_variable.summary.empty())
DataVisualization::NamedSummaryFormats::Get(ConstString(m_option_variable.summary.c_str()), summary_format_sp); DataVisualization::NamedSummaryFormats::GetSummaryFormat(ConstString(m_option_variable.summary.c_str()), summary_format_sp);
ValueObject::DumpValueObjectOptions options; ValueObject::DumpValueObjectOptions options;

32
lldb/source/Commands/CommandObjectType.cpp
View File

@ -1049,7 +1049,7 @@ CommandObjectTypeSummaryAdd::AddSummary(const ConstString& type_name,
Error* error) Error* error)
{ {
lldb::FormatCategorySP category; lldb::FormatCategorySP category;
DataVisualization::Categories::Get(ConstString(category_name.c_str()), category); DataVisualization::Categories::GetCategory(ConstString(category_name.c_str()), category);
if (type == eRegexSummary) if (type == eRegexSummary)
{ {
@ -1234,7 +1234,7 @@ public:
} }
lldb::FormatCategorySP category; lldb::FormatCategorySP category;
DataVisualization::Categories::Get(ConstString(m_options.m_category.c_str()), category); DataVisualization::Categories::GetCategory(ConstString(m_options.m_category.c_str()), category);
bool delete_category = category->Delete(typeCS, bool delete_category = category->Delete(typeCS,
eFormatCategoryItemSummary | eFormatCategoryItemRegexSummary); eFormatCategoryItemSummary | eFormatCategoryItemRegexSummary);
@ -1365,10 +1365,10 @@ public:
{ {
const char* cat_name = command.GetArgumentAtIndex(0); const char* cat_name = command.GetArgumentAtIndex(0);
ConstString cat_nameCS(cat_name); ConstString cat_nameCS(cat_name);
DataVisualization::Categories::Get(cat_nameCS, category); DataVisualization::Categories::GetCategory(cat_nameCS, category);
} }
else else
DataVisualization::Categories::Get(ConstString(NULL), category); DataVisualization::Categories::GetCategory(ConstString(NULL), category);
category->Clear(eFormatCategoryItemSummary | eFormatCategoryItemRegexSummary); category->Clear(eFormatCategoryItemSummary | eFormatCategoryItemRegexSummary);
} }
@ -1667,7 +1667,7 @@ public:
} }
DataVisualization::Categories::Enable(typeCS); DataVisualization::Categories::Enable(typeCS);
lldb::FormatCategorySP cate; lldb::FormatCategorySP cate;
if (DataVisualization::Categories::Get(typeCS, cate) && cate.get()) if (DataVisualization::Categories::GetCategory(typeCS, cate) && cate.get())
{ {
if (cate->GetCount() == 0) if (cate->GetCount() == 0)
{ {
@ -2462,7 +2462,7 @@ public:
} }
lldb::FormatCategorySP category; lldb::FormatCategorySP category;
DataVisualization::Categories::Get(ConstString(m_options.m_category.c_str()), category); DataVisualization::Categories::GetCategory(ConstString(m_options.m_category.c_str()), category);
bool delete_category = category->GetFilterNavigator()->Delete(typeCS); bool delete_category = category->GetFilterNavigator()->Delete(typeCS);
delete_category = category->GetRegexFilterNavigator()->Delete(typeCS) || delete_category; delete_category = category->GetRegexFilterNavigator()->Delete(typeCS) || delete_category;
@ -2624,7 +2624,7 @@ public:
} }
lldb::FormatCategorySP category; lldb::FormatCategorySP category;
DataVisualization::Categories::Get(ConstString(m_options.m_category.c_str()), category); DataVisualization::Categories::GetCategory(ConstString(m_options.m_category.c_str()), category);
bool delete_category = category->GetSyntheticNavigator()->Delete(typeCS); bool delete_category = category->GetSyntheticNavigator()->Delete(typeCS);
delete_category = category->GetRegexSyntheticNavigator()->Delete(typeCS) || delete_category; delete_category = category->GetRegexSyntheticNavigator()->Delete(typeCS) || delete_category;
@ -2757,10 +2757,10 @@ public:
{ {
const char* cat_name = command.GetArgumentAtIndex(0); const char* cat_name = command.GetArgumentAtIndex(0);
ConstString cat_nameCS(cat_name); ConstString cat_nameCS(cat_name);
DataVisualization::Categories::Get(cat_nameCS, category); DataVisualization::Categories::GetCategory(cat_nameCS, category);
} }
else else
DataVisualization::Categories::Get(ConstString(NULL), category); DataVisualization::Categories::GetCategory(ConstString(NULL), category);
category->GetFilterNavigator()->Clear(); category->GetFilterNavigator()->Clear();
category->GetRegexFilterNavigator()->Clear(); category->GetRegexFilterNavigator()->Clear();
} }
@ -2883,10 +2883,10 @@ public:
{ {
const char* cat_name = command.GetArgumentAtIndex(0); const char* cat_name = command.GetArgumentAtIndex(0);
ConstString cat_nameCS(cat_name); ConstString cat_nameCS(cat_name);
DataVisualization::Categories::Get(cat_nameCS, category); DataVisualization::Categories::GetCategory(cat_nameCS, category);
} }
else else
DataVisualization::Categories::Get(ConstString(NULL), category); DataVisualization::Categories::GetCategory(ConstString(NULL), category);
category->GetSyntheticNavigator()->Clear(); category->GetSyntheticNavigator()->Clear();
category->GetRegexSyntheticNavigator()->Clear(); category->GetRegexSyntheticNavigator()->Clear();
} }
@ -3037,7 +3037,7 @@ public:
lldb::FormatCategorySP category; lldb::FormatCategorySP category;
DataVisualization::Categories::Get(ConstString(options->m_category.c_str()), category); DataVisualization::Categories::GetCategory(ConstString(options->m_category.c_str()), category);
Error error; Error error;
@ -3156,7 +3156,7 @@ CommandObjectTypeSynthAdd::Execute_PythonClass (Args& command, CommandReturnObje
// now I have a valid provider, let's add it to every type // now I have a valid provider, let's add it to every type
lldb::FormatCategorySP category; lldb::FormatCategorySP category;
DataVisualization::Categories::Get(ConstString(m_options.m_category.c_str()), category); DataVisualization::Categories::GetCategory(ConstString(m_options.m_category.c_str()), category);
Error error; Error error;
@ -3215,7 +3215,7 @@ CommandObjectTypeSynthAdd::AddSynth(const ConstString& type_name,
Error* error) Error* error)
{ {
lldb::FormatCategorySP category; lldb::FormatCategorySP category;
DataVisualization::Categories::Get(ConstString(category_name.c_str()), category); DataVisualization::Categories::GetCategory(ConstString(category_name.c_str()), category);
if (category->AnyMatches(type_name, if (category->AnyMatches(type_name,
eFormatCategoryItemFilter | eFormatCategoryItemRegexFilter, eFormatCategoryItemFilter | eFormatCategoryItemRegexFilter,
@ -3392,7 +3392,7 @@ private:
Error* error) Error* error)
{ {
lldb::FormatCategorySP category; lldb::FormatCategorySP category;
DataVisualization::Categories::Get(ConstString(category_name.c_str()), category); DataVisualization::Categories::GetCategory(ConstString(category_name.c_str()), category);
if (category->AnyMatches(type_name, if (category->AnyMatches(type_name,
eFormatCategoryItemSynth | eFormatCategoryItemRegexSynth, eFormatCategoryItemSynth | eFormatCategoryItemRegexSynth,
@ -3514,7 +3514,7 @@ public:
// now I have a valid provider, let's add it to every type // now I have a valid provider, let's add it to every type
lldb::FormatCategorySP category; lldb::FormatCategorySP category;
DataVisualization::Categories::Get(ConstString(m_options.m_category.c_str()), category); DataVisualization::Categories::GetCategory(ConstString(m_options.m_category.c_str()), category);
Error error; Error error;

6
lldb/source/Core/DataVisualization.cpp
View File

@ -39,7 +39,7 @@ DataVisualization::GetCurrentRevision ()
} }
lldb::ValueFormatSP lldb::ValueFormatSP
DataVisualization::ValueFormats::Get (ValueObject& valobj, lldb::DynamicValueType use_dynamic) DataVisualization::ValueFormats::GetFormat (ValueObject& valobj, lldb::DynamicValueType use_dynamic)
{ {
lldb::ValueFormatSP entry; lldb::ValueFormatSP entry;
GetFormatManager().GetValueNavigator().Get(valobj, entry, use_dynamic); GetFormatManager().GetValueNavigator().Get(valobj, entry, use_dynamic);
@ -105,7 +105,7 @@ DataVisualization::AnyMatches (ConstString type_name,
} }
bool bool
DataVisualization::Categories::Get (const ConstString &category, lldb::FormatCategorySP &entry) DataVisualization::Categories::GetCategory (const ConstString &category, lldb::FormatCategorySP &entry)
{ {
entry = GetFormatManager().GetCategory(category); entry = GetFormatManager().GetCategory(category);
return true; return true;
@ -168,7 +168,7 @@ DataVisualization::Categories::GetCount ()
} }
bool bool
DataVisualization::NamedSummaryFormats::Get (const ConstString &type, lldb::SummaryFormatSP &entry) DataVisualization::NamedSummaryFormats::GetSummaryFormat (const ConstString &type, lldb::SummaryFormatSP &entry)
{ {
return GetFormatManager().GetNamedSummaryNavigator().Get(type,entry); return GetFormatManager().GetNamedSummaryNavigator().Get(type,entry);
} }

6
lldb/source/Core/ValueObject.cpp
View File

@ -248,9 +248,9 @@ ValueObject::UpdateFormatsIfNeeded(DynamicValueType use_dynamic)
if ( (m_last_format_mgr_revision != DataVisualization::GetCurrentRevision()) || if ( (m_last_format_mgr_revision != DataVisualization::GetCurrentRevision()) ||
m_last_format_mgr_dynamic != use_dynamic) m_last_format_mgr_dynamic != use_dynamic)
{ {
SetValueFormat(DataVisualization::ValueFormats::Get(*this, eNoDynamicValues)); SetValueFormat(DataVisualization::ValueFormats::GetFormat (*this, eNoDynamicValues));
SetSummaryFormat(DataVisualization::GetSummaryFormat(*this, use_dynamic)); SetSummaryFormat(DataVisualization::GetSummaryFormat (*this, use_dynamic));
SetSyntheticChildren(DataVisualization::GetSyntheticChildren(*this, use_dynamic)); SetSyntheticChildren(DataVisualization::GetSyntheticChildren (*this, use_dynamic));
m_last_format_mgr_revision = DataVisualization::GetCurrentRevision(); m_last_format_mgr_revision = DataVisualization::GetCurrentRevision();
m_last_format_mgr_dynamic = use_dynamic; m_last_format_mgr_dynamic = use_dynamic;