[sanitizer] Uninline slow path of PersistentAllocator::alloc

This commit is contained in:
Vitaly Buka 2021-10-07 10:13:00 -07:00
parent f4a5fb0c55
commit 78c5754813
2 changed files with 19 additions and 12 deletions

View File

@ -15,4 +15,21 @@ namespace __sanitizer {
PersistentAllocator thePersistentAllocator; PersistentAllocator thePersistentAllocator;
void *PersistentAllocator::refillAndAlloc(uptr size) {
// If failed, lock, retry and alloc new superblock.
SpinMutexLock l(&mtx);
for (;;) {
void *s = tryAlloc(size);
if (s)
return s;
atomic_store(&region_pos, 0, memory_order_relaxed);
uptr allocsz = 64 * 1024;
if (allocsz < size)
allocsz = size;
uptr mem = (uptr)MmapOrDie(allocsz, "stack depot");
atomic_store(&region_end, mem + allocsz, memory_order_release);
atomic_store(&region_pos, mem, memory_order_release);
}
}
} // namespace __sanitizer } // namespace __sanitizer

View File

@ -26,6 +26,7 @@ class PersistentAllocator {
private: private:
void *tryAlloc(uptr size); void *tryAlloc(uptr size);
void *refillAndAlloc(uptr size);
StaticSpinMutex mtx; // Protects alloc of new blocks for region allocator. StaticSpinMutex mtx; // Protects alloc of new blocks for region allocator.
atomic_uintptr_t region_pos; // Region allocator for Node's. atomic_uintptr_t region_pos; // Region allocator for Node's.
atomic_uintptr_t region_end; atomic_uintptr_t region_end;
@ -47,18 +48,7 @@ inline void *PersistentAllocator::alloc(uptr size) {
// First, try to allocate optimisitically. // First, try to allocate optimisitically.
void *s = tryAlloc(size); void *s = tryAlloc(size);
if (s) return s; if (s) return s;
// If failed, lock, retry and alloc new superblock. return refillAndAlloc(size);
SpinMutexLock l(&mtx);
for (;;) {
s = tryAlloc(size);
if (s) return s;
atomic_store(&region_pos, 0, memory_order_relaxed);
uptr allocsz = 64 * 1024;
if (allocsz < size) allocsz = size;
uptr mem = (uptr)MmapOrDie(allocsz, "stack depot");
atomic_store(&region_end, mem + allocsz, memory_order_release);
atomic_store(&region_pos, mem, memory_order_release);
}
} }
extern PersistentAllocator thePersistentAllocator; extern PersistentAllocator thePersistentAllocator;