maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

significantly speed up constant folding of calls (and thus all clients that use 

ConstantFoldInstruction on calls) by avoiding Value::getName().  getName() constructs
and returns an std::string, which does heap allocation stuff.  This slightly speeds up
instcombine.

llvm-svn: 40924
This commit is contained in:
Chris Lattner 2007-08-08 06:55:43 +00:00
parent 415750e132
commit 785f9986bd
1 changed files with 131 additions and 94 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

131
llvm/lib/Analysis/ConstantFolding.cpp
View File

@ -19,6 +19,7 @@
#include "llvm/Instructions.h" #include "llvm/Instructions.h"
#include "llvm/Intrinsics.h" #include "llvm/Intrinsics.h"
#include "llvm/ADT/SmallVector.h" #include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/StringMap.h"
#include "llvm/Target/TargetData.h" #include "llvm/Target/TargetData.h"
#include "llvm/Support/GetElementPtrTypeIterator.h" #include "llvm/Support/GetElementPtrTypeIterator.h"
#include "llvm/Support/MathExtras.h" #include "llvm/Support/MathExtras.h"
@ -312,8 +313,6 @@ Constant *llvm::ConstantFoldLoadThroughGEPConstantExpr(Constant *C,
/// the specified function. /// the specified function.
bool bool
llvm::canConstantFoldCallTo(Function *F) { llvm::canConstantFoldCallTo(Function *F) {
const std::string &Name = F->getName();
switch (F->getIntrinsicID()) { switch (F->getIntrinsicID()) {
case Intrinsic::sqrt_f32: case Intrinsic::sqrt_f32:
case Intrinsic::sqrt_f64: case Intrinsic::sqrt_f64:
@ -327,28 +326,64 @@ llvm::canConstantFoldCallTo(Function *F) {
default: break; default: break;
} }
switch (Name[0]) const ValueName *NameVal = F->getValueName();
{ const char *Str = NameVal->getKeyData();
unsigned Len = NameVal->getKeyLength();
if (Len == 0) return false;
// In these cases, the check of the length is required. We don't want to
// return true for a name like "cos\0blah" which strcmp would return equal to
// "cos", but has length 8.
switch (Str[0]) {
default: return false;
case 'a': case 'a':
return Name == "acos" || Name == "asin" || Name == "atan" || if (Len == 4)
Name == "atan2"; return !strcmp(Str, "acos") || !strcmp(Str, "asin") ||
!strcmp(Str, "atan");
else if (Len == 5)
return !strcmp(Str, "atan2");
return false;
case 'c': case 'c':
return Name == "ceil" || Name == "cos" || Name == "cosf" || if (Len == 3)
Name == "cosh"; return !strcmp(Str, "cos");
else if (Len == 4)
return !strcmp(Str, "ceil") || !strcmp(Str, "cosf") ||
!strcmp(Str, "cosh");
return false;
case 'e': case 'e':
return Name == "exp"; if (Len == 3)
return !strcmp(Str, "exp");
return false;
case 'f': case 'f':
return Name == "fabs" || Name == "fmod" || Name == "floor"; if (Len == 4)
return !strcmp(Str, "fabs") || !strcmp(Str, "fmod");
else if (Len == 5)
return !strcmp(Str, "floor");
return false;
break;
case 'l': case 'l':
return Name == "log" || Name == "log10"; if (Len == 3 && !strcmp(Str, "log"))
return true;
if (Len == 5 && !strcmp(Str, "log10"))
return true;
return false;
case 'p': case 'p':
return Name == "pow"; if (Len == 3 && !strcmp(Str, "pow"))
return true;
return false;
case 's': case 's':
return Name == "sin" || Name == "sinh" || if (Len == 3)
Name == "sqrt" || Name == "sqrtf"; return !strcmp(Str, "sin");
if (Len == 4)
return !strcmp(Str, "sinh") || !strcmp(Str, "sqrt");
if (Len == 5)
return !strcmp(Str, "sqrtf");
return false;
case 't': case 't':
return Name == "tan" || Name == "tanh"; if (Len == 3 && !strcmp(Str, "tan"))
default: return true;
else if (Len == 4 && !strcmp(Str, "tanh"))
return true;
return false; return false;
} }
} }
@ -378,46 +413,48 @@ static Constant *ConstantFoldBinaryFP(double (*NativeFP)(double, double),
/// with the specified arguments, returning null if unsuccessful. /// with the specified arguments, returning null if unsuccessful.
Constant * Constant *
llvm::ConstantFoldCall(Function *F, Constant** Operands, unsigned NumOperands) { llvm::ConstantFoldCall(Function *F, Constant** Operands, unsigned NumOperands) {
const std::string &Name = F->getName(); const ValueName *NameVal = F->getValueName();
const Type *Ty = F->getReturnType(); const char *Str = NameVal->getKeyData();
unsigned Len = NameVal->getKeyLength();
const Type *Ty = F->getReturnType();
if (NumOperands == 1) { if (NumOperands == 1) {
if (ConstantFP *Op = dyn_cast<ConstantFP>(Operands[0])) { if (ConstantFP *Op = dyn_cast<ConstantFP>(Operands[0])) {
double V = Op->getValue(); double V = Op->getValue();
switch (Name[0]) switch (Str[0]) {
{
case 'a': case 'a':
if (Name == "acos") if (Len == 4 && !strcmp(Str, "acos"))
return ConstantFoldFP(acos, V, Ty); return ConstantFoldFP(acos, V, Ty);
else if (Name == "asin") else if (Len == 4 && !strcmp(Str, "asin"))
return ConstantFoldFP(asin, V, Ty); return ConstantFoldFP(asin, V, Ty);
else if (Name == "atan") else if (Len == 4 && !strcmp(Str, "atan"))
return ConstantFoldFP(atan, V, Ty); return ConstantFoldFP(atan, V, Ty);
break; break;
case 'c': case 'c':
if (Name == "ceil") if (Len == 4 && !strcmp(Str, "ceil"))
return ConstantFoldFP(ceil, V, Ty); return ConstantFoldFP(ceil, V, Ty);
else if (Name == "cos") else if (Len == 3 && !strcmp(Str, "cos"))
return ConstantFoldFP(cos, V, Ty); return ConstantFoldFP(cos, V, Ty);
else if (Name == "cosh") else if (Len == 4 && !strcmp(Str, "cosh"))
return ConstantFoldFP(cosh, V, Ty); return ConstantFoldFP(cosh, V, Ty);
break; break;
case 'e': case 'e':
if (Name == "exp") if (Len == 3 && !strcmp(Str, "exp"))
return ConstantFoldFP(exp, V, Ty); return ConstantFoldFP(exp, V, Ty);
break; break;
case 'f': case 'f':
if (Name == "fabs") if (Len == 4 && !strcmp(Str, "fabs"))
return ConstantFP::get(Ty, fabs(V)); return ConstantFP::get(Ty, fabs(V));
else if (Name == "floor") else if (Len == 5 && !strcmp(Str, "floor"))
return ConstantFoldFP(floor, V, Ty); return ConstantFoldFP(floor, V, Ty);
break; break;
case 'l': case 'l':
if (Name == "log" && V > 0) if (Len == 3 && !strcmp(Str, "log") && V > 0)
return ConstantFoldFP(log, V, Ty); return ConstantFoldFP(log, V, Ty);
else if (Name == "log10" && V > 0) else if (Len == 5 && !strcmp(Str, "log10") && V > 0)
return ConstantFoldFP(log10, V, Ty); return ConstantFoldFP(log10, V, Ty);
else if (Name == "llvm.sqrt.f32" || Name == "llvm.sqrt.f64") { else if (!strcmp(Str, "llvm.sqrt.f32") ||
!strcmp(Str, "llvm.sqrt.f64")) {
if (V >= -0.0) if (V >= -0.0)
return ConstantFP::get(Ty, sqrt(V)); return ConstantFP::get(Ty, sqrt(V));
else // Undefined else // Undefined
@ -425,34 +462,34 @@ llvm::ConstantFoldCall(Function *F, Constant** Operands, unsigned NumOperands) {
} }
break; break;
case 's': case 's':
if (Name == "sin") if (Len == 3 && !strcmp(Str, "sin"))
return ConstantFoldFP(sin, V, Ty); return ConstantFoldFP(sin, V, Ty);
else if (Name == "sinh") else if (Len == 4 && !strcmp(Str, "sinh"))
return ConstantFoldFP(sinh, V, Ty); return ConstantFoldFP(sinh, V, Ty);
else if (Name == "sqrt" && V >= 0) else if (Len == 4 && !strcmp(Str, "sqrt") && V >= 0)
return ConstantFoldFP(sqrt, V, Ty); return ConstantFoldFP(sqrt, V, Ty);
else if (Name == "sqrtf" && V >= 0) else if (Len == 5 && !strcmp(Str, "sqrtf") && V >= 0)
return ConstantFoldFP(sqrt, V, Ty); return ConstantFoldFP(sqrt, V, Ty);
break; break;
case 't': case 't':
if (Name == "tan") if (Len == 3 && !strcmp(Str, "tan"))
return ConstantFoldFP(tan, V, Ty); return ConstantFoldFP(tan, V, Ty);
else if (Name == "tanh") else if (Len == 4 && !strcmp(Str, "tanh"))
return ConstantFoldFP(tanh, V, Ty); return ConstantFoldFP(tanh, V, Ty);
break; break;
default: default:
break; break;
} }
} else if (ConstantInt *Op = dyn_cast<ConstantInt>(Operands[0])) { } else if (ConstantInt *Op = dyn_cast<ConstantInt>(Operands[0])) {
if (Name.size() > 11 && !memcmp(&Name[0], "llvm.bswap", 10)) { if (Len > 11 && !memcmp(Str, "llvm.bswap", 10)) {
return ConstantInt::get(Op->getValue().byteSwap()); return ConstantInt::get(Op->getValue().byteSwap());
} else if (Name.size() > 11 && !memcmp(&Name[0],"llvm.ctpop",10)) { } else if (Len > 11 && !memcmp(Str, "llvm.ctpop", 10)) {
uint64_t ctpop = Op->getValue().countPopulation(); uint64_t ctpop = Op->getValue().countPopulation();
return ConstantInt::get(Ty, ctpop); return ConstantInt::get(Ty, ctpop);
} else if (Name.size() > 10 && !memcmp(&Name[0], "llvm.cttz", 9)) { } else if (Len > 10 && !memcmp(Str, "llvm.cttz", 9)) {
uint64_t cttz = Op->getValue().countTrailingZeros(); uint64_t cttz = Op->getValue().countTrailingZeros();
return ConstantInt::get(Ty, cttz); return ConstantInt::get(Ty, cttz);
} else if (Name.size() > 10 && !memcmp(&Name[0], "llvm.ctlz", 9)) { } else if (Len > 10 && !memcmp(Str, "llvm.ctlz", 9)) {
uint64_t ctlz = Op->getValue().countLeadingZeros(); uint64_t ctlz = Op->getValue().countLeadingZeros();
return ConstantInt::get(Ty, ctlz); return ConstantInt::get(Ty, ctlz);
} }
@ -463,18 +500,18 @@ llvm::ConstantFoldCall(Function *F, Constant** Operands, unsigned NumOperands) {
if (ConstantFP *Op2 = dyn_cast<ConstantFP>(Operands[1])) { if (ConstantFP *Op2 = dyn_cast<ConstantFP>(Operands[1])) {
double Op2V = Op2->getValue(); double Op2V = Op2->getValue();
if (Name == "pow") { if (Len == 3 && !strcmp(Str, "pow")) {
return ConstantFoldBinaryFP(pow, Op1V, Op2V, Ty); return ConstantFoldBinaryFP(pow, Op1V, Op2V, Ty);
} else if (Name == "fmod") { } else if (Len == 4 && !strcmp(Str, "fmod")) {
return ConstantFoldBinaryFP(fmod, Op1V, Op2V, Ty); return ConstantFoldBinaryFP(fmod, Op1V, Op2V, Ty);
} else if (Name == "atan2") { } else if (Len == 5 && !strcmp(Str, "atan2")) {
return ConstantFoldBinaryFP(atan2, Op1V, Op2V, Ty); return ConstantFoldBinaryFP(atan2, Op1V, Op2V, Ty);
} }
} else if (ConstantInt *Op2C = dyn_cast<ConstantInt>(Operands[1])) { } else if (ConstantInt *Op2C = dyn_cast<ConstantInt>(Operands[1])) {
if (Name == "llvm.powi.f32") { if (!strcmp(Str, "llvm.powi.f32")) {
return ConstantFP::get(Ty, std::pow((float)Op1V, return ConstantFP::get(Ty, std::pow((float)Op1V,
(int)Op2C->getZExtValue())); (int)Op2C->getZExtValue()));
} else if (Name == "llvm.powi.f64") { } else if (!strcmp(Str, "llvm.powi.f64")) {
return ConstantFP::get(Ty, std::pow((double)Op1V, return ConstantFP::get(Ty, std::pow((double)Op1V,
(int)Op2C->getZExtValue())); (int)Op2C->getZExtValue()));
} }