maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[CSSPGO] Do not use getCanonicalFnName in pseudo probe descriptor decoding 

Pseudo probe descriptors are created very early in the pipeline where function names just come from the front end and are not yet decorated. So calling getCanonicalFnName on the function names in probe desc is basically a no-op, which also addes a depenency from MC to ProfileData unnessesarily.

Reviewed By: wenlei, wlei

Differential Revision: https://reviews.llvm.org/D107838
This commit is contained in:
Hongtao Yu 2021-08-10 08:59:01 -07:00
parent c84c5d0520
commit 78523516bc
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
llvm/lib/MC/CMakeLists.txt
View File

@ -70,7 +70,6 @@ add_llvm_component_library(LLVMMC
Support Support
BinaryFormat BinaryFormat
DebugInfoCodeView DebugInfoCodeView
ProfileData
) )
add_subdirectory(MCParser) add_subdirectory(MCParser)

3
llvm/lib/MC/MCPseudoProbe.cpp
View File

@ -356,8 +356,7 @@ bool MCPseudoProbeDecoder::buildGUID2FuncDescMap(const uint8_t *Start,
uint64_t GUID = std::move(*ErrorOrGUID); uint64_t GUID = std::move(*ErrorOrGUID);
uint64_t Hash = std::move(*ErrorOrHash); uint64_t Hash = std::move(*ErrorOrHash);
StringRef Name = StringRef Name = std::move(*ErrorOrName);
FunctionSamples::getCanonicalFnName(std::move(*ErrorOrName));
// Initialize PseudoProbeFuncDesc and populate it into GUID2FuncDescMap // Initialize PseudoProbeFuncDesc and populate it into GUID2FuncDescMap
GUID2FuncDescMap.emplace(GUID, MCPseudoProbeFuncDesc(GUID, Hash, Name)); GUID2FuncDescMap.emplace(GUID, MCPseudoProbeFuncDesc(GUID, Hash, Name));