maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] use CHECK-NOTES in tests for bugprone suspicious-enum-usage 

Reviewers: alexfh, aaron.ballman, hokein

Subscribers: xazax.hun, cfe-commits

Differential Revision: https://reviews.llvm.org/D52229

llvm-svn: 343201
This commit is contained in:
Jonas Toth 2018-09-27 12:30:44 +00:00
parent 98f503a326
commit 7829a938c5
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
clang-tools-extra/test/clang-tidy/bugprone-suspicious-enum-usage-strict.cpp
View File

@ -10,23 +10,23 @@ enum A {
G = 63 G = 63
}; };
// CHECK-MESSAGES: :[[@LINE+2]]:1: warning: enum type seems like a bitmask (contains mostly power-of-2 literals) but a literal is not power-of-2 // CHECK-NOTES: :[[@LINE+2]]:1: warning: enum type seems like a bitmask (contains mostly power-of-2 literals) but a literal is not power-of-2
// CHECK-MESSAGES: :76:7: note: used here as a bitmask // CHECK-NOTES: :76:7: note: used here as a bitmask
enum X { enum X {
X = 8, X = 8,
Y = 16, Y = 16,
Z = 4, Z = 4,
ZZ = 3 ZZ = 3
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: enum type seems like a bitmask (contains mostly power-of-2 literals), but this literal is not a power-of-2 [bugprone-suspicious-enum-usage] // CHECK-NOTES: :[[@LINE-1]]:3: warning: enum type seems like a bitmask (contains mostly power-of-2 literals), but this literal is not a power-of-2 [bugprone-suspicious-enum-usage]
// CHECK-MESSAGES: :70:13: note: used here as a bitmask // CHECK-NOTES: :70:13: note: used here as a bitmask
}; };
// CHECK-MESSAGES: :[[@LINE+2]]:1: warning: enum type seems like a bitmask (contains mostly power-of-2 literals) but some literals are not power-of-2 // CHECK-NOTES: :[[@LINE+2]]:1: warning: enum type seems like a bitmask (contains mostly power-of-2 literals) but some literals are not power-of-2
// CHECK-MESSAGES: :73:8: note: used here as a bitmask // CHECK-NOTES: :73:8: note: used here as a bitmask
enum PP { enum PP {
P = 2, P = 2,
Q = 3, Q = 3,
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: enum type seems like a bitmask (contains mostly power-of-2 literals), but this literal is not a power-of-2 // CHECK-NOTES: :[[@LINE-1]]:3: warning: enum type seems like a bitmask (contains mostly power-of-2 literals), but this literal is not a power-of-2
// CHECK-MESSAGES: :65:11: note: used here as a bitmask // CHECK-NOTES: :65:11: note: used here as a bitmask
R = 4, R = 4,
S = 8, S = 8,
T = 16, T = 16,
@ -58,10 +58,10 @@ Days bestDay() {
int trigger() { int trigger() {
if (bestDay() | A) if (bestDay() | A)
return 1; return 1;
// CHECK-MESSAGES: :[[@LINE-2]]:17: warning: enum values are from different enum types // CHECK-NOTES: :[[@LINE-2]]:17: warning: enum values are from different enum types
if (I | Y) if (I | Y)
return 1; return 1;
// CHECK-MESSAGES: :[[@LINE-2]]:9: warning: enum values are from different enum types // CHECK-NOTES: :[[@LINE-2]]:9: warning: enum values are from different enum types
if (P + Q == R) if (P + Q == R)
return 1; return 1;
else if ((S | R) == T) else if ((S | R) == T)

4
clang-tools-extra/test/clang-tidy/bugprone-suspicious-enum-usage.cpp
View File

@ -54,10 +54,10 @@ int trigger() {
int emptytest = EmptyVal | B; int emptytest = EmptyVal | B;
if (bestDay() | A) if (bestDay() | A)
return 1; return 1;
// CHECK-MESSAGES: :[[@LINE-2]]:17: warning: enum values are from different enum types // CHECK-NOTES: :[[@LINE-2]]:17: warning: enum values are from different enum types
if (I | Y) if (I | Y)
return 1; return 1;
// CHECK-MESSAGES: :[[@LINE-2]]:9: warning: enum values are from different enum types // CHECK-NOTES: :[[@LINE-2]]:9: warning: enum values are from different enum types
} }
int dont_trigger() { int dont_trigger() {