maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[mlir] fix error handling in rocm runtime wrapper 

The patch fixes minor issues in the rocm runtime wrapper due to api differences between CUDA and HIP.

Reviewed By: herhut

Differential Revision: https://reviews.llvm.org/D84861
This commit is contained in:
Tobias Gysi 2020-07-29 22:00:48 +02:00
parent 6ce97eee35
commit 77c3b016c4
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
mlir/tools/mlir-rocm-runner/rocm-runtime-wrappers.cpp
View File

@ -25,8 +25,7 @@
[](hipError_t result) { \
if (!result) \
return; \
const char *name = nullptr; \
hipGetErrorName(result, &name); \
const char *name = hipGetErrorName(result); \
if (!name) \
name = "<unknown>"; \
llvm::errs() << "'" << #expr << "' failed with '" << name << "'\n"; \
@ -74,8 +73,7 @@ extern "C" void mgpuStreamSynchronize(hipStream_t stream) {
// Allows to register byte array with the ROCM runtime. Helpful until we have
// transfer functions implemented.
extern "C" void mgpuMemHostRegister(void *ptr, uint64_t sizeBytes) {
HIP_REPORT_IF_ERROR(hipHostRegister(ptr, sizeBytes, /*flags=*/0),
"MemHostRegister");
HIP_REPORT_IF_ERROR(hipHostRegister(ptr, sizeBytes, /*flags=*/0));
}
// Allows to register a MemRef with the ROCM runtime. Initializes array with
@ -116,10 +114,9 @@ extern "C" void mgpuMemHostRegisterInt32(int64_t rank, void *ptr) {
template <typename T>
void mgpuMemGetDevicePointer(T *hostPtr, T **devicePtr) {
HIP_REPORT_IF_ERROR(hipSetDevice(0), "hipSetDevice");
HIP_REPORT_IF_ERROR(hipSetDevice(0));
HIP_REPORT_IF_ERROR(
hipHostGetDevicePointer((void **)devicePtr, hostPtr, /*flags=*/0),
"hipHostGetDevicePointer");
hipHostGetDevicePointer((void **)devicePtr, hostPtr, /*flags=*/0));
}
extern "C" StridedMemRefType<float, 1>