maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Reimplement TargetMachineRegistry in terms of TargetRegistry. 

- This is a temporary hack to aid in incremental refactoring, for now we
   allocate a new TargetMachineRegistryEntry on every getClosest... call.

 - No intended functionality change, other than the leaked memory.

llvm-svn: 75766
This commit is contained in:
Daniel Dunbar 2009-07-15 09:53:37 +00:00
parent 39d2781b04
commit 776fe8db5f
2 changed files with 16 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/include/llvm/Target/TargetRegistry.h
View File

@ -49,6 +49,8 @@ namespace llvm {
bool);
friend struct TargetRegistry;
// FIXME: Temporary hack, please remove.
friend struct TargetMachineRegistry;
/// Next - The next registered target in the linked list, maintained by the
/// TargetRegistry.

55
llvm/lib/Target/TargetMachineRegistry.cpp
View File

@ -24,27 +24,14 @@ using namespace llvm;
const TargetMachineRegistry::entry *
TargetMachineRegistry::getClosestStaticTargetForModule(const Module &M,
std::string &Error) {
std::vector<std::pair<unsigned, const entry *> > UsableTargets;
for (Registry<TargetMachine>::iterator I = begin(), E = end(); I != E; ++I)
if (unsigned Qual = I->ModuleMatchQualityFn(M))
UsableTargets.push_back(std::make_pair(Qual, &*I));
if (UsableTargets.empty()) {
Error = "No available targets are compatible with this module";
const Target *T = TargetRegistry::getClosestStaticTargetForModule(M, Error);
if (!T)
return 0;
} else if (UsableTargets.size() == 1)
return UsableTargets.back().second;
// Otherwise, take the best target, but make sure we don't have two equally
// good best targets.
std::sort(UsableTargets.begin(), UsableTargets.end());
if (UsableTargets.back().first ==UsableTargets[UsableTargets.size()-2].first){
Error = "Cannot choose between targets \"" +
std::string(UsableTargets.back().second->Name) + "\" and \"" +
std::string(UsableTargets[UsableTargets.size()-2].second->Name) + "\"";
return 0;
}
return UsableTargets.back().second;
// FIXME: Temporary hack, please remove.
return new TargetMachineRegistry::entry(T->Name, T->ShortDesc,
T->TargetMachineCtorFn,
T->ModuleMatchQualityFn,
T->JITMatchQualityFn);
}
/// getClosestTargetForJIT - Pick the best target that is compatible with
@ -52,27 +39,13 @@ TargetMachineRegistry::getClosestStaticTargetForModule(const Module &M,
/// and sets the Error string to a reason.
const TargetMachineRegistry::entry *
TargetMachineRegistry::getClosestTargetForJIT(std::string &Error) {
std::vector<std::pair<unsigned, const entry *> > UsableTargets;
for (Registry<TargetMachine>::iterator I = begin(), E = end(); I != E; ++I)
if (unsigned Qual = I->JITMatchQualityFn())
UsableTargets.push_back(std::make_pair(Qual, &*I));
if (UsableTargets.empty()) {
Error = "No JIT is available for this host";
const Target *T = TargetRegistry::getClosestTargetForJIT(Error);
if (!T)
return 0;
} else if (UsableTargets.size() == 1)
return UsableTargets.back().second;
// Otherwise, take the best target. If there is a tie, just pick one.
unsigned MaxQual = UsableTargets.front().first;
const entry *MaxQualTarget = UsableTargets.front().second;
for (unsigned i = 1, e = UsableTargets.size(); i != e; ++i)
if (UsableTargets[i].first > MaxQual) {
MaxQual = UsableTargets[i].first;
MaxQualTarget = UsableTargets[i].second;
}
return MaxQualTarget;
// FIXME: Temporary hack, please remove.
return new TargetMachineRegistry::entry(T->Name, T->ShortDesc,
T->TargetMachineCtorFn,
T->ModuleMatchQualityFn,
T->JITMatchQualityFn);
}