maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[BlockGenerator] Insert initializations at beginning of start block 

In case some code -- not guarded by control flow -- would be emitted directly in
the start block, it may happen that this code would use uninitalized scalar
values if the scalar initialization is only emitted at the end of the start
block. This is not a problem today in normal Polly, as all statements are
emitted in their own basic blocks, but Polly-ACC emits host-to-device copy
statements into the start block.

Additional Polly-ACC test coverage will be added in subsequent changes that
improve the handling of PHI nodes in Polly-ACC.

llvm-svn: 278124
This commit is contained in:
Tobias Grosser 2016-08-09 15:34:59 +00:00
parent 8cef2c2f2d
commit 776700d0b7
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
polly/lib/CodeGen/BlockGenerators.cpp
View File

@ -484,7 +484,7 @@ void BlockGenerator::createScalarInitialization(Scop &S) {
if (StartBB == S.getEntry())
StartBB = SplitBBTerm->getSuccessor(1);
Builder.SetInsertPoint(StartBB->getTerminator());
Builder.SetInsertPoint(&*StartBB->begin());
for (auto &Array : S.arrays()) {
if (Array->getNumberOfDimensions() != 0)

2
polly/test/Isl/CodeGen/phi_loop_carried_float.ll
View File

@ -17,8 +17,8 @@
; CHECK-NEXT: ret
; CHECK-LABEL: polly.start:
; CHECK-NEXT: sext
; CHECK-NEXT: store float 0.000000e+00, float* %tmp.0.phiops
; CHECK-NEXT: sext
; CHECK-LABEL: polly.exiting:
; CHECK-NEXT: br label %polly.merge_new_and_old

2
polly/test/Isl/CodeGen/phi_loop_carried_float_escape.ll
View File

@ -16,8 +16,8 @@
; CHECK-NEXT: br label %exit
; CHECK-LABEL: polly.start:
; CHECK-NEXT: sext
; CHECK-NEXT: store float 0.000000e+00, float* %tmp.0.phiops
; CHECK-NEXT: sext
; CHECK-LABEL: polly.exiting:
; CHECK-NEXT: %tmp.0.final_reload = load float, float* %tmp.0.s2a

2
polly/test/Isl/CodeGen/phi_scalar_simple_2.ll
View File

@ -28,8 +28,8 @@ entry:
; CHECK: ret i32 %x.addr.0.merge
; CHECK-LABEL: polly.start:
; CHECK-NEXT: sext
; CHECK-NEXT: store i32 %x, i32* %x.addr.0.phiops
; CHECK-NEXT: sext
; CHECK-LABEL: polly.merge21:
; CHECK: %x.addr.0.final_reload = load i32, i32* %x.addr.0.s2a