maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[mlir][drr] Improve error message for unexpected attribute (NFC) 

When using an attribute where a value is expected previously this would fail
complaining about unbound symbol. Instead make error clear and mention common
failure reason.
This commit is contained in:
Jacques Pienaar 2021-08-10 13:03:52 -07:00
parent 178da37b18
commit 768a517581
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mlir/tools/mlir-tblgen/RewriterGen.cpp
View File

@ -1295,6 +1295,14 @@ void PatternEmitter::createAggregateLocalVarsForOpArgs(
childNodeNames.lookup(argIndex)); childNodeNames.lookup(argIndex));
} else { } else {
DagLeaf leaf = node.getArgAsLeaf(argIndex); DagLeaf leaf = node.getArgAsLeaf(argIndex);
if (leaf.isConstantAttr())
// TODO: Use better location
PrintFatalError(
loc,
"attribute found where value was expected, if attempting to use "
"constant value, construct a constant op with given attribute "
"instead");
auto symbol = auto symbol =
symbolInfoMap.getValueAndRangeUse(node.getArgName(argIndex)); symbolInfoMap.getValueAndRangeUse(node.getArgName(argIndex));
if (leaf.isNativeCodeCall()) { if (leaf.isNativeCodeCall()) {