maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

retain/release checker: More diagnostic refactoring. 

llvm-svn: 63179
This commit is contained in:
Ted Kremenek 2009-01-28 05:15:02 +00:00
parent c4118ac79c
commit 758fda632b
1 changed files with 15 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
clang/lib/Analysis/CFRefCount.cpp
View File

@ -2331,36 +2331,24 @@ PathDiagnosticPiece* CFRefReport::VisitNode(const ExplodedNode<GRState>* N,
Stmt* S = cast<PostStmt>(N->getLocation()).getStmt();
if (CurrV.isOwned()) {
if (CallExpr *CE = dyn_cast<CallExpr>(S)) {
// Get the name of the callee (if it is available).
SVal X = CurrSt.GetSVal(CE->getCallee());
if (loc::FuncVal* FV = dyn_cast<loc::FuncVal>(&X))
os << "Call to function '" << FV->getDecl()->getNameAsString() <<'\'';
else
os << "Function call";
os << " returns an object with a +1 retain count"
" (owning reference).";
}
else {
assert (isa<ObjCMessageExpr>(S));
os << "Method returns an object with a +1 retain count"
" (owning reference).";
}
if (CallExpr *CE = dyn_cast<CallExpr>(S)) {
// Get the name of the callee (if it is available).
SVal X = CurrSt.GetSVal(CE->getCallee());
if (loc::FuncVal* FV = dyn_cast<loc::FuncVal>(&X))
os << "Call to function '" << FV->getDecl()->getNameAsString() <<'\'';
else
os << "function call";
}
else {
assert (isa<ObjCMessageExpr>(S));
os << "Method returns an object with a ";
}
if (CurrV.isOwned())
os << "+1 retain count (owning reference).";
else {
assert (CurrV.isNotOwned());
if (isa<CallExpr>(S))
os << "Function call returns an object with a +0 retain count"
" (non-owning reference).";
else {
assert (isa<ObjCMessageExpr>(S));
os << "Method returns an object with a +0 retain count"
" (non-owning reference).";
}
os << "+0 retain count (non-owning reference).";
}
FullSourceLoc Pos(S->getLocStart(), BR.getContext().getSourceManager());