maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lld-macho][nfc] Add absolute-vs-non-absolute symbol test for ICF 

Make sure we don't wrongly fold two sections that refer to
symbols with the same value if they are not both absolute /
non-absolute.

Reviewed By: #lld-macho, gkm

Differential Revision: https://reviews.llvm.org/D104876
This commit is contained in:
Jez Ng 2021-06-28 14:43:36 -04:00
parent 557e1fa02f
commit 74d5f30d83
1 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
lld/test/MachO/icf.s
View File

@ -13,6 +13,7 @@
# CHECK: [[#%x,A]] g F __TEXT,__text _a2 # CHECK: [[#%x,A]] g F __TEXT,__text _a2
# CHECK: [[#%x,A]] g F __TEXT,__text _a3 # CHECK: [[#%x,A]] g F __TEXT,__text _a3
# CHECK: [[#%x,B:]] g F __TEXT,__text _b # CHECK: [[#%x,B:]] g F __TEXT,__text _b
# CHECK: [[#%x,B2:]] g F __TEXT,__text _b2
# CHECK: [[#%x,C:]] g F __TEXT,__text _c # CHECK: [[#%x,C:]] g F __TEXT,__text _c
# CHECK: [[#%x,D:]] g F __TEXT,__text _d # CHECK: [[#%x,D:]] g F __TEXT,__text _d
# CHECK: [[#%x,E:]] g F __TEXT,__text _e # CHECK: [[#%x,E:]] g F __TEXT,__text _e
@ -34,6 +35,7 @@
# CHECK-NEXT: callq 0x[[#%x,A]] <_a3> # CHECK-NEXT: callq 0x[[#%x,A]] <_a3>
# CHECK-NEXT: callq 0x[[#%x,A]] <_a3> # CHECK-NEXT: callq 0x[[#%x,A]] <_a3>
# CHECK-NEXT: callq 0x[[#%x,B]] <_b> # CHECK-NEXT: callq 0x[[#%x,B]] <_b>
# CHECK-NEXT: callq 0x[[#%x,B2]] <_b2>
# CHECK-NEXT: callq 0x[[#%x,C]] <_c> # CHECK-NEXT: callq 0x[[#%x,C]] <_c>
# CHECK-NEXT: callq 0x[[#%x,D]] <_d> # CHECK-NEXT: callq 0x[[#%x,D]] <_d>
# CHECK-NEXT: callq 0x[[#%x,E]] <_e> # CHECK-NEXT: callq 0x[[#%x,E]] <_e>
@ -53,14 +55,20 @@
### TODO: ### TODO:
### * Fold: funcs only differ in alignment ### * Fold: funcs only differ in alignment
### * No fold: func is weak? preemptable? ### * No fold: func is weak? preemptable?
### * Test that we hash things appropriately w/ minimal collisions
#--- abs.s #--- abs.s
.subsections_via_symbols .subsections_via_symbols
.globl _abs1a, _abs1b, _abs2 .globl _abs1a, _abs1b, _abs2, _not_abs
_abs1a = 0xfeedfac3 _abs1a = 0xfac3
_abs1b = 0xfeedfac3 _abs1b = 0xfac3
_abs2 = 0xfeedf00d _abs2 = 0xf00d
.data
.space 0xfac3
## _not_abs has the same Defined::value as _abs1{a,b}
_not_abs:
#--- main.s #--- main.s
.subsections_via_symbols .subsections_via_symbols
@ -116,6 +124,18 @@ _b:
movl $0, %eax movl $0, %eax
ret ret
### No fold: _not_abs has the same value as _abs1{a,b}, but is not absolute.
.globl _b2
.p2align 2
_b2:
callq _d
mov ___nan@GOTPCREL(%rip), %rax
callq ___isnan
movabs $_not_abs, %rdx
movl $0, %eax
ret
### No fold: _c has slightly different body from _a1 & _a2 ### No fold: _c has slightly different body from _a1 & _a2
.globl _c .globl _c
@ -282,6 +302,7 @@ _main:
callq _a2 callq _a2
callq _a3 callq _a3
callq _b callq _b
callq _b2
callq _c callq _c
callq _d callq _d
callq _e callq _e