maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[RewriteStatepointsForGC] Delete trivial code 

A bit more code cleanup: delete some a trivial true assertion and supporting code, remove a redundant cast, and use count in assertions where feasible.

llvm-svn: 242805
This commit is contained in:
Philip Reames 2015-07-21 16:51:17 +00:00
parent 9cb7933d51
commit 74ce2e7691
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
View File

@ -1164,10 +1164,7 @@ static void CreateGCRelocates(ArrayRef<llvm::Value *> LiveVariables,
ArrayRef<llvm::Value *> BasePtrs,
Instruction *StatepointToken,
IRBuilder<> Builder) {
SmallVector<Instruction *, 64> NewDefs;
NewDefs.reserve(LiveVariables.size());
Module *M = StatepointToken->getParent()->getParent()->getParent();
Module *M = StatepointToken->getModule();
for (unsigned i = 0; i < LiveVariables.size(); i++) {
// We generate a (potentially) unique declaration for every pointer type
@ -1189,18 +1186,14 @@ static void CreateGCRelocates(ArrayRef<llvm::Value *> LiveVariables,
Builder.getInt32(LiveStart + find_index(LiveVariables, LiveVariables[i]));
// only specify a debug name if we can give a useful one
Value *Reloc = Builder.CreateCall(
CallInst *Reloc = Builder.CreateCall(
GCRelocateDecl, {StatepointToken, BaseIdx, LiveIdx},
LiveVariables[i]->hasName() ? LiveVariables[i]->getName() + ".relocated"
: "");
// Trick CodeGen into thinking there are lots of free registers at this
// fake call.
cast<CallInst>(Reloc)->setCallingConv(CallingConv::Cold);
NewDefs.push_back(cast<Instruction>(Reloc));
Reloc->setCallingConv(CallingConv::Cold);
}
assert(NewDefs.size() == LiveVariables.size() &&
"missing or extra redefinition at safepoint");
}
static void
@ -1396,8 +1389,7 @@ makeStatepointExplicit(DominatorTree &DT, const CallSite &CS, Pass *P,
basevec.reserve(liveset.size());
for (Value *L : liveset) {
livevec.push_back(L);
assert(PointerToBase.find(L) != PointerToBase.end());
assert(PointerToBase.count(L));
Value *base = PointerToBase[L];
basevec.push_back(base);
}
@ -1957,7 +1949,7 @@ static void rematerializeLiveValues(CallSite CS,
for (Value *LiveValue: Info.liveset) {
// For each live pointer find it's defining chain
SmallVector<Instruction *, 3> ChainToBase;
assert(Info.PointerToBase.find(LiveValue) != Info.PointerToBase.end());
assert(Info.PointerToBase.count(LiveValue));
bool FoundChain =
findRematerializableChainToBasePointer(ChainToBase,
LiveValue,