From 7470fb01d00e559eb9bed5fe00ba7feeb427d5f9 Mon Sep 17 00:00:00 2001 From: Jakub Staszak Date: Fri, 2 Sep 2011 14:57:37 +0000 Subject: [PATCH] Compare type size instead of type _store_ size to make sure that BitCastInst will be valid. This fixes PR10820. llvm-svn: 139005 --- llvm/lib/Transforms/Scalar/GVN.cpp | 4 ++-- llvm/test/Transforms/GVN/pr10820.ll | 17 +++++++++++++++++ 2 files changed, 19 insertions(+), 2 deletions(-) create mode 100644 llvm/test/Transforms/GVN/pr10820.ll diff --git a/llvm/lib/Transforms/Scalar/GVN.cpp b/llvm/lib/Transforms/Scalar/GVN.cpp index 3b4c252990a6..e3f61b5dff72 100644 --- a/llvm/lib/Transforms/Scalar/GVN.cpp +++ b/llvm/lib/Transforms/Scalar/GVN.cpp @@ -689,8 +689,8 @@ static Value *CoerceAvailableValueToLoadType(Value *StoredVal, // If this is already the right type, just return it. Type *StoredValTy = StoredVal->getType(); - uint64_t StoreSize = TD.getTypeStoreSizeInBits(StoredValTy); - uint64_t LoadSize = TD.getTypeStoreSizeInBits(LoadedTy); + uint64_t StoreSize = TD.getTypeSizeInBits(StoredValTy); + uint64_t LoadSize = TD.getTypeSizeInBits(LoadedTy); // If the store and reload are the same size, we can always reuse it. if (StoreSize == LoadSize) { diff --git a/llvm/test/Transforms/GVN/pr10820.ll b/llvm/test/Transforms/GVN/pr10820.ll new file mode 100644 index 000000000000..024257143875 --- /dev/null +++ b/llvm/test/Transforms/GVN/pr10820.ll @@ -0,0 +1,17 @@ +; RUN: opt < %s -basicaa -gvn -S | FileCheck %s + +target datalayout = +"e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-f128:128:128-n8:16:32:64" +target triple = "x86_64-unknown-linux-gnu" + +@g = external global i31 + +define void @main() nounwind uwtable { +entry: +; CHECK: store i32 + store i32 402662078, i32* bitcast (i31* @g to i32*), align 8 + %0 = load i31* @g, align 8 +; CHECK: store i31 + store i31 %0, i31* undef, align 1 + unreachable +}