maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[codeview] Improve some comments 

This FIXME was already fixed, and these LF_* enum names were
inconsistent.

llvm-svn: 268683
This commit is contained in:
Reid Kleckner 2016-05-05 20:58:46 +00:00
parent 777dc513a0
commit 745f3cbcfc
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/include/llvm/DebugInfo/CodeView/TypeRecord.h
View File

@ -299,7 +299,7 @@ struct FuncId {
// Name: The null-terminated name follows. // Name: The null-terminated name follows.
}; };
// LF_CLASS, LF_STRUCT, LF_INTERFACE // LF_CLASS, LF_STRUCTURE, LF_INTERFACE
struct ClassType { struct ClassType {
ulittle16_t MemberCount; // Number of members in FieldList. ulittle16_t MemberCount; // Number of members in FieldList.
ulittle16_t Properties; // ClassOptions bitset ulittle16_t Properties; // ClassOptions bitset
@ -501,6 +501,7 @@ struct OneMethod {
bool isIntroducedVirtual() const { return Attrs.isIntroducedVirtual(); } bool isIntroducedVirtual() const { return Attrs.isIntroducedVirtual(); }
}; };
// LF_METHODLIST
struct MethodListEntry { struct MethodListEntry {
MemberAttributes Attrs; MemberAttributes Attrs;
ulittle16_t Padding; ulittle16_t Padding;
@ -559,7 +560,7 @@ struct BaseClass {
// BaseOffset: LF_NUMERIC encoded byte offset of base from derived. // BaseOffset: LF_NUMERIC encoded byte offset of base from derived.
}; };
// LF_VBCLASS | LV_IVBCLASS // LF_VBCLASS, LF_IVBCLASS
struct VirtualBaseClass { struct VirtualBaseClass {
MemberAttributes Attrs; // Access control attributes, etc. MemberAttributes Attrs; // Access control attributes, etc.
TypeIndex BaseType; // Base class type TypeIndex BaseType; // Base class type

1
llvm/lib/DebugInfo/CodeView/TypeDumper.cpp
View File

@ -200,7 +200,6 @@ public:
: CVTD(CVTD), W(W), PrintRecordBytes(PrintRecordBytes) {} : CVTD(CVTD), W(W), PrintRecordBytes(PrintRecordBytes) {}
/// CVTypeVisitor overrides. /// CVTypeVisitor overrides.
/// FIXME: Bury these in the .cc file to hide implementation details.
#define TYPE_RECORD(ClassName, LeafEnum) \ #define TYPE_RECORD(ClassName, LeafEnum) \
void visit##ClassName(TypeLeafKind LeafType, const ClassName *Record, \ void visit##ClassName(TypeLeafKind LeafType, const ClassName *Record, \
ArrayRef<uint8_t> LeafData); ArrayRef<uint8_t> LeafData);