maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[mlir][SymbolTable] Small optimization to walking symbol references 

* Check region count for unknown symbol tables first, as it is a faster check
* Add an accessor to MutableDictionaryAttr to get the internal dictionary without creating a new one if it is empty. This avoids an otherwise unnecessary lookup of an MLIRContext.
This commit is contained in:
River Riddle 2020-10-28 22:00:55 -07:00
parent fa4174792a
commit 73547b08de
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mlir/include/mlir/IR/Attributes.h
View File

@ -1621,6 +1621,10 @@ public:
/// Return the underlying dictionary attribute.
DictionaryAttr getDictionary(MLIRContext *context) const;
/// Return the underlying dictionary attribute or null if there are no
/// attributes within this dictionary.
DictionaryAttr getDictionaryOrNull() const { return attrs; }
/// Return all of the attributes on this operation.
ArrayRef<NamedAttribute> getAttrs() const;

6
mlir/lib/IR/SymbolTable.cpp
View File

@ -17,7 +17,7 @@ using namespace mlir;
/// Return true if the given operation is unknown and may potentially define a
/// symbol table.
static bool isPotentiallyUnknownSymbolTable(Operation *op) {
return !op->getDialect() && op->getNumRegions() == 1;
return op->getNumRegions() == 1 && !op->getDialect();
}
/// Returns the string name of the given symbol, or None if this is not a
@ -442,9 +442,9 @@ static WalkResult walkSymbolRefs(
Operation *op,
function_ref<WalkResult(SymbolTable::SymbolUse, ArrayRef<int>)> callback) {
// Check to see if the operation has any attributes.
if (op->getMutableAttrDict().empty())
DictionaryAttr attrDict = op->getMutableAttrDict().getDictionaryOrNull();
if (!attrDict)
return WalkResult::advance();
DictionaryAttr attrDict = op->getAttrDictionary();
// A worklist of a container attribute and the current index into the held
// attribute list.