forked from OSchip/llvm-project
ThinLTO: Remove check for multiple modules before applying weak resolutions.
This check is not only unnecessary, it can produce the wrong result. If we are linking a single module and it has an exported linkonce symbol, we need to promote to weak in order to avoid PR19901-style problems. Differential Revision: http://reviews.llvm.org/D21917 llvm-svn: 274722
This commit is contained in:
parent
cd7194629b
commit
730c82e6b8
|
@ -92,10 +92,6 @@ void thinLTOResolveWeakForLinkerInIndex(
|
|||
function_ref<bool(StringRef, GlobalValue::GUID)> isExported,
|
||||
function_ref<void(StringRef, GlobalValue::GUID, GlobalValue::LinkageTypes)>
|
||||
recordNewLinkage) {
|
||||
if (Index.modulePaths().size() == 1)
|
||||
// Nothing to do if we don't have multiple modules
|
||||
return;
|
||||
|
||||
// We won't optimize the globals that are referenced by an alias for now
|
||||
// Ideally we should turn the alias into a global and duplicate the definition
|
||||
// when needed.
|
||||
|
|
|
@ -0,0 +1,9 @@
|
|||
; RUN: opt -module-summary %s -o %t.bc
|
||||
; RUN: llvm-lto -thinlto-action=thinlink -o %t2.bc %t.bc
|
||||
|
||||
; RUN: llvm-lto -thinlto-action=promote %t.bc -thinlto-index=%t2.bc -exported-symbol=foo -o - | llvm-lto -thinlto-action=internalize -thinlto-module-id=%t.bc - -thinlto-index=%t2.bc -exported-symbol=foo -o - | llvm-dis -o - | FileCheck %s
|
||||
|
||||
; CHECK: define weak_odr void @foo()
|
||||
define linkonce_odr void @foo() {
|
||||
ret void
|
||||
}
|
Loading…
Reference in New Issue