maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

fix PR8063, a crash in globalopt in the malloc analysis code. 

llvm-svn: 113109
This commit is contained in:
Chris Lattner 2010-09-05 17:20:46 +00:00
parent 64a4a13617
commit 72d283c826
2 changed files with 44 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
llvm/lib/Analysis/ValueTracking.cpp
View File

@ -880,19 +880,20 @@ bool llvm::ComputeMultiple(Value *V, unsigned Base, Value *&Multiple,
} }
Value *Mul0 = NULL; Value *Mul0 = NULL;
Value *Mul1 = NULL; if (ComputeMultiple(Op0, Base, Mul0, LookThroughSExt, Depth+1)) {
bool M0 = ComputeMultiple(Op0, Base, Mul0, if (Constant *Op1C = dyn_cast<Constant>(Op1))
LookThroughSExt, Depth+1); if (Constant *MulC = dyn_cast<Constant>(Mul0)) {
bool M1 = ComputeMultiple(Op1, Base, Mul1, if (Op1C->getType()->getPrimitiveSizeInBits() <
LookThroughSExt, Depth+1); MulC->getType()->getPrimitiveSizeInBits())
Op1C = ConstantExpr::getZExt(Op1C, MulC->getType());
if (M0) { if (Op1C->getType()->getPrimitiveSizeInBits() >
if (isa<Constant>(Op1) && isa<Constant>(Mul0)) { MulC->getType()->getPrimitiveSizeInBits())
// V == Base * (Mul0 * Op1), so return (Mul0 * Op1) MulC = ConstantExpr::getZExt(MulC, Op1C->getType());
Multiple = ConstantExpr::getMul(cast<Constant>(Mul0),
cast<Constant>(Op1)); // V == Base * (Mul0 * Op1), so return (Mul0 * Op1)
return true; Multiple = ConstantExpr::getMul(MulC, Op1C);
} return true;
}
if (ConstantInt *Mul0CI = dyn_cast<ConstantInt>(Mul0)) if (ConstantInt *Mul0CI = dyn_cast<ConstantInt>(Mul0))
if (Mul0CI->getValue() == 1) { if (Mul0CI->getValue() == 1) {
@ -902,13 +903,21 @@ bool llvm::ComputeMultiple(Value *V, unsigned Base, Value *&Multiple,
} }
} }
if (M1) { Value *Mul1 = NULL;
if (isa<Constant>(Op0) && isa<Constant>(Mul1)) { if (ComputeMultiple(Op1, Base, Mul1, LookThroughSExt, Depth+1)) {
// V == Base * (Mul1 * Op0), so return (Mul1 * Op0) if (Constant *Op0C = dyn_cast<Constant>(Op0))
Multiple = ConstantExpr::getMul(cast<Constant>(Mul1), if (Constant *MulC = dyn_cast<Constant>(Mul1)) {
cast<Constant>(Op0)); if (Op0C->getType()->getPrimitiveSizeInBits() <
return true; MulC->getType()->getPrimitiveSizeInBits())
} Op0C = ConstantExpr::getZExt(Op0C, MulC->getType());
if (Op0C->getType()->getPrimitiveSizeInBits() >
MulC->getType()->getPrimitiveSizeInBits())
MulC = ConstantExpr::getZExt(MulC, Op0C->getType());
// V == Base * (Mul1 * Op0), so return (Mul1 * Op0)
Multiple = ConstantExpr::getMul(MulC, Op0C);
return true;
}
if (ConstantInt *Mul1CI = dyn_cast<ConstantInt>(Mul1)) if (ConstantInt *Mul1CI = dyn_cast<ConstantInt>(Mul1))
if (Mul1CI->getValue() == 1) { if (Mul1CI->getValue() == 1) {

15
llvm/test/Transforms/GlobalOpt/crash.ll
View File

@ -40,3 +40,18 @@ xx:
} }
declare noalias i8* @malloc(i64) nounwind declare noalias i8* @malloc(i64) nounwind
; PR8063
@permute_bitrev.bitrev = internal global i32* null, align 8
define void @permute_bitrev() nounwind {
entry:
%tmp = load i32** @permute_bitrev.bitrev, align 8
%conv = sext i32 0 to i64
%mul = mul i64 %conv, 4
%call = call i8* @malloc(i64 %mul)
%0 = bitcast i8* %call to i32*
store i32* %0, i32** @permute_bitrev.bitrev, align 8
ret void
}