maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Performance improvements to the IsObjCNil () - we only try to resolve the value if the variable under consideration truly is an “Objective-C thing” 

This also changes the ClangASTContext to make sure that id is correctly marked as being such an ObjC thing

llvm-svn: 177203
This commit is contained in:
Enrico Granata 2013-03-15 23:33:15 +00:00
parent 7b641e97ed
commit 7277d201a9
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lldb/source/Core/ValueObject.cpp
View File

@ -1899,10 +1899,13 @@ ValueObject::IsPossibleDynamicType ()
bool
ValueObject::IsObjCNil ()
{
bool isObjCpointer = ClangASTContext::IsObjCObjectPointerType(GetClangType(), NULL);
const uint32_t mask = ClangASTContext::eTypeIsObjC | ClangASTContext::eTypeIsPointer;
bool isObjCpointer = ( ((ClangASTContext::GetTypeInfo(GetClangType(), GetClangAST(), NULL)) & mask) == mask);
if (!isObjCpointer)
return false;
bool canReadValue = true;
bool isZero = GetValueAsUnsigned(0,&canReadValue) == 0;
return canReadValue && isZero && isObjCpointer;
return canReadValue && isZero;
}
ValueObjectSP

2
lldb/source/Symbol/ClangASTContext.cpp
View File

@ -2920,7 +2920,7 @@ ClangASTContext::GetTypeInfo
case clang::BuiltinType::ObjCClass:
if (ast && pointee_or_element_clang_type)
*pointee_or_element_clang_type = ast->ObjCBuiltinClassTy.getAsOpaquePtr();
return eTypeIsBuiltIn | eTypeIsPointer | eTypeHasValue;
return eTypeIsBuiltIn | eTypeIsPointer | eTypeHasValue | eTypeIsObjC;
break;
case clang::BuiltinType::Bool:
case clang::BuiltinType::Char_U: