maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Apply clang-tidy fixes for readability-identifier-naming in PolynomialApproximation.cpp (NFC)

This commit is contained in:
Mehdi Amini 2022-01-30 09:56:28 +00:00
parent bb6119eb77
commit 70ed93ec4c
1 changed files with 22 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
mlir/lib/Dialect/Math/Transforms/PolynomialApproximation.cpp
View File

@ -325,8 +325,8 @@ AtanApproximation::matchAndRewrite(math::AtanOp op,
p = builder.create<arith::MulFOp>(x, p); p = builder.create<arith::MulFOp>(x, p);
// Remap the solution for over [0.0, 1.0] to [0.0, inf] // Remap the solution for over [0.0, 1.0] to [0.0, inf]
auto half_pi = broadcast(builder, f32Cst(builder, 1.57079632679f), shape); auto halfPi = broadcast(builder, f32Cst(builder, 1.57079632679f), shape);
Value sub = builder.create<arith::SubFOp>(half_pi, p); Value sub = builder.create<arith::SubFOp>(halfPi, p);
Value select = builder.create<SelectOp>(compare, p, sub); Value select = builder.create<SelectOp>(compare, p, sub);
// Correct for signing of the input. // Correct for signing of the input.
@ -366,40 +366,38 @@ Atan2Approximation::matchAndRewrite(math::Atan2Op op,
// Determine what the atan would be for a 180 degree rotation. // Determine what the atan would be for a 180 degree rotation.
auto zero = broadcast(builder, f32Cst(builder, 0.0f), shape); auto zero = broadcast(builder, f32Cst(builder, 0.0f), shape);
auto pi = broadcast(builder, f32Cst(builder, 3.14159265359f), shape); auto pi = broadcast(builder, f32Cst(builder, 3.14159265359f), shape);
auto add_pi = builder.create<arith::AddFOp>(atan, pi); auto addPi = builder.create<arith::AddFOp>(atan, pi);
auto sub_pi = builder.create<arith::SubFOp>(atan, pi); auto subPi = builder.create<arith::SubFOp>(atan, pi);
auto atan_gt = auto atanGt =
builder.create<arith::CmpFOp>(arith::CmpFPredicate::OGT, atan, zero); builder.create<arith::CmpFOp>(arith::CmpFPredicate::OGT, atan, zero);
auto flipped_atan = builder.create<SelectOp>(atan_gt, sub_pi, add_pi); auto flippedAtan = builder.create<SelectOp>(atanGt, subPi, addPi);
// Determine whether to directly use atan or use the 180 degree flip // Determine whether to directly use atan or use the 180 degree flip
auto x_gt = builder.create<arith::CmpFOp>(arith::CmpFPredicate::OGT, x, zero); auto xGt = builder.create<arith::CmpFOp>(arith::CmpFPredicate::OGT, x, zero);
Value result = builder.create<SelectOp>(x_gt, atan, flipped_atan); Value result = builder.create<SelectOp>(xGt, atan, flippedAtan);
// Handle x = 0, y > 0 // Handle x = 0, y > 0
Value x_zero = Value xZero =
builder.create<arith::CmpFOp>(arith::CmpFPredicate::OEQ, x, zero); builder.create<arith::CmpFOp>(arith::CmpFPredicate::OEQ, x, zero);
Value y_gt = Value yGt = builder.create<arith::CmpFOp>(arith::CmpFPredicate::OGT, y, zero);
builder.create<arith::CmpFOp>(arith::CmpFPredicate::OGT, y, zero); Value isHalfPi = builder.create<arith::AndIOp>(xZero, yGt);
Value is_half_pi = builder.create<arith::AndIOp>(x_zero, y_gt); auto halfPi = broadcast(builder, f32Cst(builder, 1.57079632679f), shape);
auto half_pi = broadcast(builder, f32Cst(builder, 1.57079632679f), shape); result = builder.create<SelectOp>(isHalfPi, halfPi, result);
result = builder.create<SelectOp>(is_half_pi, half_pi, result);
// Handle x = 0, y < 0 // Handle x = 0, y < 0
Value y_lt = Value yLt = builder.create<arith::CmpFOp>(arith::CmpFPredicate::OLT, y, zero);
builder.create<arith::CmpFOp>(arith::CmpFPredicate::OLT, y, zero); Value isNegativeHalfPiPi = builder.create<arith::AndIOp>(xZero, yLt);
Value is_negative_half_pi_pi = builder.create<arith::AndIOp>(x_zero, y_lt); auto negativeHalfPiPi =
auto negative_half_pi_pi =
broadcast(builder, f32Cst(builder, -1.57079632679), shape); broadcast(builder, f32Cst(builder, -1.57079632679), shape);
result = builder.create<SelectOp>(is_negative_half_pi_pi, negative_half_pi_pi, result =
result); builder.create<SelectOp>(isNegativeHalfPiPi, negativeHalfPiPi, result);
// Handle x = 0, y = 0; // Handle x = 0, y = 0;
Value y_zero = Value yZero =
builder.create<arith::CmpFOp>(arith::CmpFPredicate::OEQ, y, zero); builder.create<arith::CmpFOp>(arith::CmpFPredicate::OEQ, y, zero);
Value is_nan = builder.create<arith::AndIOp>(x_zero, y_zero); Value isNan = builder.create<arith::AndIOp>(xZero, yZero);
Value cst_nan = broadcast(builder, f32FromBits(builder, 0x7fc00000), shape); Value cstNan = broadcast(builder, f32FromBits(builder, 0x7fc00000), shape);
result = builder.create<SelectOp>(is_nan, cst_nan, result); result = builder.create<SelectOp>(isNan, cstNan, result);
rewriter.replaceOp(op, result); rewriter.replaceOp(op, result);
return success(); return success();