From 709f773a8884bb74239aac16d91deea8591a5ede Mon Sep 17 00:00:00 2001 From: Lang Hames Date: Wed, 11 Jul 2018 06:46:17 +0000 Subject: [PATCH] Revert r336760: "[ORC] Add unit tests for the reexports utility that were..." This patch broke a few buildbots. I will investigate and re-apply when I have a fix. llvm-svn: 336767 --- llvm/lib/ExecutionEngine/Orc/Core.cpp | 2 +- .../ExecutionEngine/Orc/CoreAPIsTest.cpp | 42 ------------------- 2 files changed, 1 insertion(+), 43 deletions(-) diff --git a/llvm/lib/ExecutionEngine/Orc/Core.cpp b/llvm/lib/ExecutionEngine/Orc/Core.cpp index 7272cd6014d4..38f2213a85f1 100644 --- a/llvm/lib/ExecutionEngine/Orc/Core.cpp +++ b/llvm/lib/ExecutionEngine/Orc/Core.cpp @@ -462,7 +462,7 @@ void ReExportsMaterializationUnit::materialize( // FIXME: We're creating a SymbolFlagsMap and a std::map of // std::sets just to add one dependency here. This needs a // re-think. - Resolved.insert(KV.second.Aliasee); + Resolved.insert(KV.first); } QueryInfo->R.resolve(ResolutionMap); diff --git a/llvm/unittests/ExecutionEngine/Orc/CoreAPIsTest.cpp b/llvm/unittests/ExecutionEngine/Orc/CoreAPIsTest.cpp index 60354cca6f31..68911d75877b 100644 --- a/llvm/unittests/ExecutionEngine/Orc/CoreAPIsTest.cpp +++ b/llvm/unittests/ExecutionEngine/Orc/CoreAPIsTest.cpp @@ -300,48 +300,6 @@ TEST_F(CoreAPIsStandardTest, TestChainedAliases) { << "\"Baz\"'s address should match \"Foo\"'s"; } -TEST_F(CoreAPIsStandardTest, TestBasicReExports) { - // Test that the basic use case of re-exporting a single symbol from another - // VSO works. - cantFail(V.define(absoluteSymbols({{Foo, FooSym}}))); - - auto &V2 = ES.createVSO("V2"); - - cantFail(V2.define(reexports(V, {{Bar, {Foo, BarSym.getFlags()}}}))); - - auto Result = cantFail(lookup({&V2}, Bar)); - EXPECT_EQ(Result.getAddress(), FooSym.getAddress()) - << "Re-export Bar for symbol Foo should match FooSym's address"; -} - -TEST_F(CoreAPIsStandardTest, TestThatReExportsDontUnnecessarilyMaterialize) { - // Test that re-exports do not materialize symbols that have not been queried - // for. - cantFail(V.define(absoluteSymbols({{Foo, FooSym}}))); - - bool BarMaterialized = false; - auto BarMU = llvm::make_unique( - SymbolFlagsMap({{Bar, BarSym.getFlags()}}), - [&](MaterializationResponsibility R) { - BarMaterialized = true; - R.resolve({{Bar, BarSym}}); - R.finalize(); - }); - - cantFail(V.define(BarMU)); - - auto &V2 = ES.createVSO("V2"); - - cantFail(V2.define(reexports( - V, {{Baz, {Foo, BazSym.getFlags()}}, {Qux, {Bar, QuxSym.getFlags()}}}))); - - auto Result = cantFail(lookup({&V2}, Baz)); - EXPECT_EQ(Result.getAddress(), FooSym.getAddress()) - << "Re-export Baz for symbol Foo should match FooSym's address"; - - EXPECT_FALSE(BarMaterialized) << "Bar should not have been materialized"; -} - TEST_F(CoreAPIsStandardTest, TestTrivialCircularDependency) { Optional FooR; auto FooMU = llvm::make_unique(