maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[scudo/standalone] Fix leak in ThreadedGlobalQuarantine test 

This unit test code was using malloc without a corresponding free.
When the system malloc is not being overridden by the code under
test, it might an asan/lsan allocator that notices leaks.

Reviewed By: phosek

Differential Revision: https://reviews.llvm.org/D91472
This commit is contained in:
Roland McGrath 2020-11-13 22:22:54 -08:00
parent 4364539b3a
commit 6ef07111a4
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
compiler-rt/lib/scudo/standalone/tests/quarantine_test.cpp
View File

@ -219,12 +219,17 @@ TEST(ScudoQuarantineTest, GlobalQuarantine) {
Str.output();
}
void *populateQuarantine(void *Param) {
struct PopulateQuarantineThread {
pthread_t Thread;
QuarantineT *Quarantine;
CacheT Cache;
Cache.init();
QuarantineT *Quarantine = reinterpret_cast<QuarantineT *>(Param);
};
void *populateQuarantine(void *Param) {
PopulateQuarantineThread *P = static_cast<PopulateQuarantineThread *>(Param);
P->Cache.init();
for (scudo::uptr I = 0; I < 128UL; I++)
Quarantine->put(&Cache, Cb, FakePtr, LargeBlockSize);
P->Quarantine->put(&P->Cache, Cb, FakePtr, LargeBlockSize);
return 0;
}
@ -233,13 +238,18 @@ TEST(ScudoQuarantineTest, ThreadedGlobalQuarantine) {
Quarantine.init(MaxQuarantineSize, MaxCacheSize);
const scudo::uptr NumberOfThreads = 32U;
pthread_t T[NumberOfThreads];
PopulateQuarantineThread T[NumberOfThreads];
for (scudo::uptr I = 0; I < NumberOfThreads; I++) {
T[I].Quarantine = &Quarantine;
pthread_create(&T[I].Thread, 0, populateQuarantine, &T[I]);
}
for (scudo::uptr I = 0; I < NumberOfThreads; I++)
pthread_create(&T[I], 0, populateQuarantine, &Quarantine);
for (scudo::uptr I = 0; I < NumberOfThreads; I++)
pthread_join(T[I], 0);
pthread_join(T[I].Thread, 0);
scudo::ScopedString Str(1024);
Quarantine.getStats(&Str);
Str.output();
for (scudo::uptr I = 0; I < NumberOfThreads; I++)
Quarantine.drainAndRecycle(&T[I].Cache, Cb);
}