maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

retain/release checker: more hacks to workaround false positives cause by 

delegates. When a reference counted object is passed as to a 'void*' argument to
a method stop tracking the reference count.

llvm-svn: 69984
This commit is contained in:
Ted Kremenek 2009-04-24 18:00:17 +00:00
parent 21895e0b89
commit 6e86cafca3
1 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
clang/lib/Analysis/CFRefCount.cpp
View File

@ -1076,9 +1076,28 @@ RetainSummaryManager::getInitMethodSummary(ObjCMessageExpr* ME) {
RetainSummary*
RetainSummaryManager::getCommonMethodSummary(ObjCMessageExpr* ME, const char *s)
{
if (ObjCMethodDecl *MD = ME->getMethodDecl()) {
// Scan the method decl for 'void*' arguments. These should be treated
// as 'StopTracking' because they are often used with delegates.
// Delegates are a frequent form of false positives with the retain
// count checker.
unsigned i = 0;
for (ObjCMethodDecl::param_iterator I = MD->param_begin(),
E = MD->param_end(); I != E; ++I, ++i)
if (ParmVarDecl *PD = *I) {
QualType Ty = Ctx.getCanonicalType(PD->getType());
if (Ty.getUnqualifiedType() == Ctx.VoidPtrTy)
ScratchArgs.push_back(std::make_pair(i, StopTracking));
}
}
// Look for methods that return an owned object.
if (!isTrackedObjectType(ME->getType()))
return 0;
if (!isTrackedObjectType(ME->getType())) {
if (ScratchArgs.empty())
return 0;
return getPersistentSummary(RetEffect::MakeNoRet());
}
// EXPERIMENTAL: Assume the Cocoa conventions for all objects returned
// by instance methods.