maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Lint] Don't warn about passing alloca'd value to tail call if using byval 

Summary:
This fixes PR35241.

When using byval, the data is effectively copied as part of the call
anyway, so the pointer returned by the alloca will not be leaked to the
callee and thus there is no reason to issue a warning.

Reviewers: rnk

Reviewed By: rnk

Subscribers: Ka-Ka, llvm-commits

Differential Revision: https://reviews.llvm.org/D40009

llvm-svn: 318279
This commit is contained in:
Mikael Holmen 2017-11-15 07:46:48 +00:00
parent 16a91cee6c
commit 6e60297ee6
2 changed files with 50 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
llvm/lib/Analysis/Lint.cpp
View File

@ -285,15 +285,24 @@ void Lint::visitCallSite(CallSite CS) {
}
}
if (CS.isCall() && cast<CallInst>(CS.getInstruction())->isTailCall())
for (CallSite::arg_iterator AI = CS.arg_begin(), AE = CS.arg_end();
AI != AE; ++AI) {
Value *Obj = findValue(*AI, /*OffsetOk=*/true);
Assert(!isa<AllocaInst>(Obj),
"Undefined behavior: Call with \"tail\" keyword references "
"alloca",
&I);
if (CS.isCall()) {
const CallInst *CI = cast<CallInst>(CS.getInstruction());
if (CI->isTailCall()) {
const AttributeList &PAL = CI->getAttributes();
unsigned ArgNo = 0;
for (Value *Arg : CS.args()) {
// Skip ByVal arguments since they will be memcpy'd to the callee's
// stack anyway.
if (PAL.hasParamAttribute(ArgNo++, Attribute::ByVal))
continue;
Value *Obj = findValue(Arg, /*OffsetOk=*/true);
Assert(!isa<AllocaInst>(Obj),
"Undefined behavior: Call with \"tail\" keyword references "
"alloca",
&I);
}
}
}
if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(&I))

33
llvm/test/Analysis/Lint/tail-call-byval.ll Normal file
View File

@ -0,0 +1,33 @@
; RUN: opt < %s -lint -disable-output 2>&1 | FileCheck %s
%s = type { i8 }
declare void @f1(%s*)
define void @f2() {
entry:
%c = alloca %s
tail call void @f1(%s* %c)
ret void
}
; Lint should complain about the tail call passing the alloca'd value %c to f1.
; CHECK: Undefined behavior: Call with "tail" keyword references alloca
; CHECK-NEXT: tail call void @f1(%s* %c)
declare void @f3(%s* byval)
define void @f4() {
entry:
%c = alloca %s
tail call void @f3(%s* byval %c)
ret void
}
; Lint should not complain about passing the alloca'd %c since it's passed
; byval, effectively copying the data to the stack instead of leaking the
; pointer itself.
; CHECK-NOT: Undefined behavior: Call with "tail" keyword references alloca
; CHECK-NOT: tail call void @f3(%s* byval %c)