maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Do not use llvm_unreachable at reachable code. 

These lines can be reachable if we give a broken or unsupported
input object file.

llvm-svn: 219176
This commit is contained in:
Rui Ueyama 2014-10-07 00:40:54 +00:00
parent c0b4c20e5e
commit 6d930787a7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lld/lib/ReaderWriter/PECOFF/WriterPECOFF.cpp
View File

@ -558,7 +558,7 @@ void AtomChunk::applyRelocationsX86_32(uint8_t *buffer,
targetAddr - getSectionStartAddr(targetAddr, sectionRva);
break;
default:
llvm_unreachable("Unsupported relocation kind");
llvm::report_fatal_error("Unsupported relocation kind");
}
}
}
@ -618,7 +618,7 @@ void AtomChunk::applyRelocationsX86_64(uint8_t *buffer,
break;
default:
llvm::errs() << "Kind: " << (int)ref->kindValue() << "\n";
llvm_unreachable("Unsupported relocation kind");
llvm::report_fatal_error("Unsupported relocation kind");
}
}
}
@ -934,7 +934,7 @@ StringRef chooseSectionByContent(const DefinedAtom *atom) {
}
llvm::errs() << "Atom: contentType=" << atom->contentType()
<< " permission=" << atom->permissions() << "\n";
llvm_unreachable("Failed to choose section based on content");
llvm::report_fatal_error("Failed to choose section based on content");
}
typedef std::map<StringRef, std::vector<const DefinedAtom *> > AtomVectorMap;