maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] Add FixItHint for performance-noexcept-move-constructor 

Differential Revision: https://reviews.llvm.org/D65104

llvm-svn: 367785
This commit is contained in:
Zinovy Nis 2019-08-04 13:32:39 +00:00
parent 436fd52a71
commit 6d83ab0870
2 changed files with 81 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp
View File

@ -9,6 +9,7 @@
#include "NoexceptMoveConstructorCheck.h" #include "NoexceptMoveConstructorCheck.h"
#include "clang/AST/ASTContext.h" #include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h" #include "clang/ASTMatchers/ASTMatchFinder.h"
#include "clang/Tooling/FixIt.h"
using namespace clang::ast_matchers; using namespace clang::ast_matchers;
@ -47,9 +48,20 @@ void NoexceptMoveConstructorCheck::check(
return; return;
if (!isNoexceptExceptionSpec(ProtoType->getExceptionSpecType())) { if (!isNoexceptExceptionSpec(ProtoType->getExceptionSpecType())) {
diag(Decl->getLocation(), "move %0s should be marked noexcept") auto Diag =
diag(Decl->getLocation(), "move %0s should be marked noexcept")
<< MethodType; << MethodType;
// FIXME: Add a fixit. // Add FixIt hints.
SourceManager &SM = *Result.SourceManager;
assert(Decl->getNumParams() > 0);
SourceLocation NoexceptLoc = Decl->getParamDecl(Decl->getNumParams() - 1)
->getSourceRange()
.getEnd();
if (NoexceptLoc.isValid())
NoexceptLoc = Lexer::findLocationAfterToken(
NoexceptLoc, tok::r_paren, SM, Result.Context->getLangOpts(), true);
if (NoexceptLoc.isValid())
Diag << FixItHint::CreateInsertion(NoexceptLoc, " noexcept ");
return; return;
} }

67
clang-tools-extra/test/clang-tidy/performance-noexcept-move-constructor-fix.cpp Normal file
View File

@ -0,0 +1,67 @@
// RUN: %check_clang_tidy %s performance-noexcept-move-constructor %t
struct C_1 {
~C_1() {}
C_1(int a) {}
C_1(C_1&& a) :C_1(5) {}
// CHECK-FIXES: ){{.*}}noexcept{{.*}}:
C_1& operator=(C_1&&) { return *this; }
// CHECK-FIXES: ){{.*}}noexcept{{.*}} {
};
struct C_2 {
~C_2() {}
C_2(C_2&& a);
// CHECK-FIXES: ){{.*}}noexcept{{.*}};
C_2& operator=(C_2&&);
// CHECK-FIXES: ){{.*}}noexcept{{.*}};
};
C_2::C_2(C_2&& a) {}
// CHECK-FIXES: ){{.*}}noexcept{{.*}} {}
C_2& C_2::operator=(C_2&&) { return *this; }
// CHECK-FIXES: ){{.*}}noexcept{{.*}} {
struct C_3 {
~C_3() {}
C_3(C_3&& a);
// CHECK-FIXES: ){{.*}}noexcept{{.*}};
C_3& operator=(C_3&& a);
// CHECK-FIXES: ){{.*}}noexcept{{.*}};
};
C_3::C_3(C_3&& a) = default;
// CHECK-FIXES: ){{.*}}noexcept{{.*}} = default;
C_3& C_3::operator=(C_3&& a) = default;
// CHECK-FIXES: ){{.*}}noexcept{{.*}} = default;
template <class T>
struct C_4 {
C_4(C_4<T>&&) {}
// CHECK-FIXES: ){{.*}}noexcept{{.*}} {}
~C_4() {}
C_4& operator=(C_4&& a) = default;
// CHECK-FIXES: ){{.*}}noexcept{{.*}} = default;
};
template <class T>
struct C_5 {
C_5(C_5<T>&&) {}
// CHECK-FIXES:){{.*}}noexcept{{.*}} {}
~C_5() {}
auto operator=(C_5&& a)->C_5<T> = default;
// CHECK-FIXES:){{.*}}noexcept{{.*}} = default;
};
template <class T>
struct C_6 {
C_6(C_6<T>&&) {}
// CHECK-FIXES:){{.*}}noexcept{{.*}} {}
~C_6() {}
auto operator=(C_6&& a)->C_6<T>;
// CHECK-FIXES:){{.*}}noexcept{{.*}};
};
template <class T>
auto C_6<T>::operator=(C_6<T>&& a) -> C_6<T> {}
// CHECK-FIXES: ){{.*}}noexcept{{.*}} {}