Clarify a FIXME.

llvm-svn: 75422
This commit is contained in:
Daniel Dunbar 2009-07-12 19:45:34 +00:00
parent a3c69aeb65
commit 6d6023b5f7
1 changed files with 5 additions and 4 deletions

View File

@ -196,7 +196,8 @@ TEST_F(SmallVectorTest, ResizeGrowTest) {
theVector.resize(2); theVector.resize(2);
// XXX: I don't know where the extra construct/destruct is coming from. // The extra constructor/destructor calls come from the temporary object used
// to initialize the contents of the resized array (via copy construction).
EXPECT_EQ(3, Constructable::getNumConstructorCalls()); EXPECT_EQ(3, Constructable::getNumConstructorCalls());
EXPECT_EQ(1, Constructable::getNumDestructorCalls()); EXPECT_EQ(1, Constructable::getNumDestructorCalls());
EXPECT_EQ(2u, theVector.size()); EXPECT_EQ(2u, theVector.size());
@ -214,16 +215,16 @@ TEST_F(SmallVectorTest, ResizeFillTest) {
TEST_F(SmallVectorTest, OverflowTest) { TEST_F(SmallVectorTest, OverflowTest) {
SCOPED_TRACE("OverflowTest"); SCOPED_TRACE("OverflowTest");
// Push more elements than the fixed size // Push more elements than the fixed size.
makeSequence(theVector, 1, 10); makeSequence(theVector, 1, 10);
// test size and values // Test size and values.
EXPECT_EQ(10u, theVector.size()); EXPECT_EQ(10u, theVector.size());
for (int i = 0; i < 10; ++i) { for (int i = 0; i < 10; ++i) {
EXPECT_EQ(i+1, theVector[i].getValue()); EXPECT_EQ(i+1, theVector[i].getValue());
} }
// Now resize back to fixed size // Now resize back to fixed size.
theVector.resize(1); theVector.resize(1);
assertValuesInOrder(theVector, 1u, 1); assertValuesInOrder(theVector, 1u, 1);