maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

SemaExpr.cpp - use castAs<> instead of getAs<> as we dereference the pointer directly. NFCI. 

castAs<> will assert the correct cast type instead of just returning null, which we then try to dereference immediately.
This commit is contained in:
Simon Pilgrim 2020-11-24 16:51:55 +00:00
parent 7e7106d104
commit 6d56823116
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/lib/Sema/SemaExpr.cpp
View File

@ -15166,7 +15166,7 @@ void Sema::ActOnBlockArguments(SourceLocation CaretLoc, Declarator &ParamInfo,
CurBlock->TheDecl->setSignatureAsWritten(Sig); CurBlock->TheDecl->setSignatureAsWritten(Sig);
CurBlock->FunctionType = T; CurBlock->FunctionType = T;
const FunctionType *Fn = T->getAs<FunctionType>(); const auto *Fn = T->castAs<FunctionType>();
QualType RetTy = Fn->getReturnType(); QualType RetTy = Fn->getReturnType();
bool isVariadic = bool isVariadic =
(isa<FunctionProtoType>(Fn) && cast<FunctionProtoType>(Fn)->isVariadic()); (isa<FunctionProtoType>(Fn) && cast<FunctionProtoType>(Fn)->isVariadic());