maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Thread Safety Analysis: move warnings on range-based for loops out of beta 

and into -Wthread-safety.

llvm-svn: 221410
This commit is contained in:
DeLesley Hutchins 2014-11-05 23:09:28 +00:00
parent 70f3897b0a
commit 6d41f38c74
1 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
clang/lib/Analysis/ThreadSafety.cpp
View File

@ -1403,19 +1403,17 @@ void BuildLockset::checkAccess(const Expr *Exp, AccessKind AK,
SourceLocation Loc = Exp->getExprLoc();
if (Analyzer->Handler.issueBetaWarnings()) {
// Local variables of reference type cannot be re-assigned;
// map them to their initializer.
while (const auto *DRE = dyn_cast<DeclRefExpr>(Exp)) {
const auto *VD = dyn_cast<VarDecl>(DRE->getDecl()->getCanonicalDecl());
if (VD && VD->isLocalVarDecl() && VD->getType()->isReferenceType()) {
if (const auto *E = VD->getInit()) {
Exp = E;
continue;
}
// Local variables of reference type cannot be re-assigned;
// map them to their initializer.
while (const auto *DRE = dyn_cast<DeclRefExpr>(Exp)) {
const auto *VD = dyn_cast<VarDecl>(DRE->getDecl()->getCanonicalDecl());
if (VD && VD->isLocalVarDecl() && VD->getType()->isReferenceType()) {
if (const auto *E = VD->getInit()) {
Exp = E;
continue;
}
break;
}
break;
}
if (const UnaryOperator *UO = dyn_cast<UnaryOperator>(Exp)) {