maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[TableGen] Don't dereference from dyn_cast<> - use cast<> instead. NFCI. 

dyn_cast<> can return null if the cast fails, resulting in null dereferences and static analyzer warnings. We should use cast<> instead.
This commit is contained in:
Simon Pilgrim 2020-12-14 12:12:08 +00:00
parent 5a02bf4f95
commit 6c8ded0d8c
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
llvm/lib/TableGen/Record.cpp
View File

@ -856,12 +856,12 @@ static StringInit *interleaveStringList(const ListInit *List,
const StringInit *Delim) {
if (List->size() == 0)
return StringInit::get("");
SmallString<80> Result(dyn_cast<StringInit>(List->getElement(0))->getValue());
SmallString<80> Result(cast<StringInit>(List->getElement(0))->getValue());
StringInit::StringFormat Fmt = StringInit::SF_String;
for (unsigned I = 1, E = List->size(); I < E; ++I) {
Result.append(Delim->getValue());
auto *StrInit = dyn_cast<StringInit>(List->getElement(I));
auto *StrInit = cast<StringInit>(List->getElement(I));
Result.append(StrInit->getValue());
Fmt = StringInit::determineFormat(Fmt, StrInit->getFormat());
}
@ -872,13 +872,14 @@ static StringInit *interleaveIntList(const ListInit *List,
const StringInit *Delim) {
if (List->size() == 0)
return StringInit::get("");
SmallString<80> Result(dyn_cast<IntInit>(List->getElement(0)->
getCastTo(IntRecTy::get()))->getAsString());
SmallString<80> Result(
cast<IntInit>(List->getElement(0)->getCastTo(IntRecTy::get()))
->getAsString());
for (unsigned I = 1, E = List->size(); I < E; ++I) {
Result.append(Delim->getValue());
Result.append(dyn_cast<IntInit>(List->getElement(I)->
getCastTo(IntRecTy::get()))->getAsString());
Result.append(cast<IntInit>(List->getElement(I)->getCastTo(IntRecTy::get()))
->getAsString());
}
return StringInit::get(Result);
}