diff --git a/clang/lib/Sema/SemaCodeComplete.cpp b/clang/lib/Sema/SemaCodeComplete.cpp index fa76db4c6387..cc8726de9df8 100644 --- a/clang/lib/Sema/SemaCodeComplete.cpp +++ b/clang/lib/Sema/SemaCodeComplete.cpp @@ -5370,6 +5370,19 @@ void Sema::CodeCompleteObjCPropertySynthesizeIvar(Scope *S, Class = cast(Container)->getCategoryDecl() ->getClassInterface(); + // Determine the type of the property we're synthesizing. + QualType PropertyType = Context.getObjCIdType(); + if (Class) { + if (ObjCPropertyDecl *Property + = Class->FindPropertyDeclaration(PropertyName)) { + PropertyType + = Property->getType().getNonReferenceType().getUnqualifiedType(); + + // Give preference to ivars + Results.setPreferredType(PropertyType); + } + } + // Add all of the instance variables in this class and its superclasses. Results.EnterNewScope(); bool SawSimilarlyNamedIvar = false; @@ -5379,39 +5392,38 @@ void Sema::CodeCompleteObjCPropertySynthesizeIvar(Scope *S, std::string NameWithSuffix = PropertyName->getName().str(); NameWithSuffix += '_'; for(; Class; Class = Class->getSuperClass()) { - // FIXME: We could screen the type of each ivar for compatibility with - // the property, but is that being too paternal? for (ObjCIvarDecl *Ivar = Class->all_declared_ivar_begin(); Ivar; Ivar = Ivar->getNextIvar()) { + Results.AddResult(Result(Ivar, 0), CurContext, 0, false); + // Determine whether we've seen an ivar with a name similar to the // property. - if (!SawSimilarlyNamedIvar && - (PropertyName->getName() == Ivar->getName() || + if ((PropertyName == Ivar->getIdentifier() || NameWithPrefix == Ivar->getName() || - NameWithSuffix == Ivar->getName())) + NameWithSuffix == Ivar->getName())) { SawSimilarlyNamedIvar = true; - - Results.AddResult(Result(Ivar, 0), CurContext, 0, false); + + // Reduce the priority of this result by one, to give it a slight + // advantage over other results whose names don't match so closely. + if (Results.size() && + Results.data()[Results.size() - 1].Kind + == CodeCompletionResult::RK_Declaration && + Results.data()[Results.size() - 1].Declaration == Ivar) + Results.data()[Results.size() - 1].Priority--; + } } } if (!SawSimilarlyNamedIvar) { // Create ivar result _propName, that the user can use to synthesize - // an ivar of the appropriate type. - QualType T = Context.getObjCIdType(); - - if (Class) { - if (ObjCPropertyDecl *Property - = Class->FindPropertyDeclaration(PropertyName)) - T = Property->getType().getNonReferenceType().getUnqualifiedType(); - } - - unsigned Priority = CCP_MemberDeclaration; + // an ivar of the appropriate type. + unsigned Priority = CCP_MemberDeclaration + 1; typedef CodeCompletionResult Result; CodeCompletionAllocator &Allocator = Results.getAllocator(); CodeCompletionBuilder Builder(Allocator, Priority,CXAvailability_Available); - Builder.AddResultTypeChunk(GetCompletionTypeString(T, Context, Allocator)); + Builder.AddResultTypeChunk(GetCompletionTypeString(PropertyType, Context, + Allocator)); Builder.AddTypedTextChunk(Allocator.CopyString(NameWithPrefix)); Results.AddResult(Result(Builder.TakeString(), Priority, CXCursor_ObjCIvarDecl)); diff --git a/clang/test/Index/complete-properties.m b/clang/test/Index/complete-properties.m index c513a91e95f5..ce1870e6511b 100644 --- a/clang/test/Index/complete-properties.m +++ b/clang/test/Index/complete-properties.m @@ -29,6 +29,22 @@ id test(I3 *i3) { return i3.Prop3; } +@interface I4 +@property id Prop2; +@end + +@interface I4 () { + I4 *Prop1; +} +@end + +@implementation I4 { + id Prop2_; +} + +@synthesize Prop2 = Prop2_; +@end + // RUN: c-index-test -code-completion-at=%s:20:13 %s | FileCheck -check-prefix=CHECK-CC1 %s // CHECK-CC1: ObjCPropertyDecl:{ResultType int}{TypedText Prop0} // CHECK-CC1: ObjCPropertyDecl:{ResultType int}{TypedText Prop1} @@ -41,9 +57,9 @@ id test(I3 *i3) { // CHECK-CC2-NEXT: ObjCPropertyDecl:{ResultType id}{TypedText Prop3} // CHECK-CC2: ObjCPropertyDecl:{ResultType id}{TypedText Prop4} // RUN: c-index-test -code-completion-at=%s:20:35 %s | FileCheck -check-prefix=CHECK-CC3 %s -// CHECK-CC3: ObjCIvarDecl:{ResultType id}{TypedText _Prop3} (35) +// CHECK-CC3: ObjCIvarDecl:{ResultType id}{TypedText _Prop3} (36) // CHECK-CC3: ObjCIvarDecl:{ResultType int}{TypedText RandomIVar} (35) -// CHECK-CC3: ObjCIvarDecl:{ResultType id}{TypedText StoredProp3} (35) +// CHECK-CC3: ObjCIvarDecl:{ResultType id}{TypedText StoredProp3} (8) // RUN: c-index-test -code-completion-at=%s:21:10 %s | FileCheck -check-prefix=CHECK-CC4 %s // CHECK-CC4: ObjCPropertyDecl:{ResultType int}{TypedText Prop0} @@ -59,3 +75,8 @@ id test(I3 *i3) { // RUN: c-index-test -code-completion-at=%s:9:11 %s | FileCheck -check-prefix=CHECK-CC6 %s // CHECK-CC6: ObjCInterfaceDecl:{TypedText MyClass} (50) + +// RUN: c-index-test -code-completion-at=%s:45:21 -fobjc-nonfragile-abi %s | FileCheck -check-prefix=CHECK-CC7 %s +// CHECK-CC7-NOT: ObjCIvarDecl:{ResultType id}{TypedText _Prop2} +// CHECK-CC7: ObjCIvarDecl:{ResultType I4 *}{TypedText Prop1} (17) +// CHECK-CC7: ObjCIvarDecl:{ResultType id}{TypedText Prop2_} (7)