maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[SVE] Fix bug in SVEIntrinsicOpts::optimizePTest 

The code wasn't taking into account that the two operands
passed to ptest could be identical and was trying to erase
them twice.

Differential Revision: https://reviews.llvm.org/D85892
This commit is contained in:
David Sherwood 2020-08-13 10:44:12 +01:00
parent 725400f993
commit 6c7957c990
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/Target/AArch64/SVEIntrinsicOpts.cpp
View File

@ -160,7 +160,7 @@ bool SVEIntrinsicOpts::optimizePTest(IntrinsicInst *I) {
I->eraseFromParent(); I->eraseFromParent();
if (Op1->use_empty()) if (Op1->use_empty())
Op1->eraseFromParent(); Op1->eraseFromParent();
if (Op2->use_empty()) if (Op1 != Op2 && Op2->use_empty())
Op2->eraseFromParent(); Op2->eraseFromParent();
return true; return true;

10
llvm/test/CodeGen/AArch64/sve-intrinsic-opts-ptest.ll
View File

@ -44,6 +44,16 @@ define i1 @ptest_first(<vscale x 4 x i1> %a) {
ret i1 %out ret i1 %out
} }
define i1 @ptest_first_same_ops(<vscale x 2 x i1> %a) {
; OPT-LABEL: ptest_first_same_ops
; OPT: %[[OUT:.*]] = call i1 @llvm.aarch64.sve.ptest.first.nxv2i1(<vscale x 2 x i1> %a, <vscale x 2 x i1> %a)
; OPT-NOT: convert
; OPT-NEXT: ret i1 %[[OUT]]
%1 = tail call <vscale x 16 x i1> @llvm.aarch64.sve.convert.to.svbool.nxv2i1(<vscale x 2 x i1> %a)
%2 = tail call i1 @llvm.aarch64.sve.ptest.first.nxv16i1(<vscale x 16 x i1> %1, <vscale x 16 x i1> %1)
ret i1 %2
}
define i1 @ptest_last(<vscale x 8 x i1> %a) { define i1 @ptest_last(<vscale x 8 x i1> %a) {
; OPT-LABEL: ptest_last ; OPT-LABEL: ptest_last
; OPT: %mask = tail call <vscale x 8 x i1> @llvm.aarch64.sve.ptrue.nxv8i1(i32 0) ; OPT: %mask = tail call <vscale x 8 x i1> @llvm.aarch64.sve.ptrue.nxv8i1(i32 0)