maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Attributor][NFC] Unify the way we delete dead functions

This commit is contained in:
Johannes Doerfert 2020-01-02 16:53:37 -06:00
parent c90681b681
commit 6b9ee2d6cd
1 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
llvm/lib/Transforms/IPO/Attributor.cpp
View File

@ -5695,13 +5695,6 @@ ChangeStatus Attributor::run(Module &M) {
BUILD_STAT_NAME(AAIsDead, BasicBlock) += ToBeDeletedBlocks.size();
}
STATS_DECL(AAIsDead, Function, "Number of dead functions deleted.");
for (Function *Fn : ToBeDeletedFunctions) {
Fn->replaceAllUsesWith(UndefValue::get(Fn->getType()));
Fn->eraseFromParent();
STATS_TRACK(AAIsDead, Function);
}
// Identify dead internal functions and delete them. This happens outside
// the other fixpoint analysis as we might treat potentially dead functions
// as live to lower the number of iterations. If they happen to be dead, the
@ -5719,15 +5712,15 @@ ChangeStatus Attributor::run(Module &M) {
if (!F)
continue;
if (!checkForAllCallSites([](AbstractCallSite ACS) { return false; },
*F, true, nullptr))
if (!checkForAllCallSites(
[this](AbstractCallSite ACS) {
return ToBeDeletedFunctions.count(
ACS.getInstruction()->getFunction());
},
*F, true, nullptr))
continue;
STATS_TRACK(AAIsDead, Function);
ToBeDeletedFunctions.insert(F);
F->deleteBody();
F->replaceAllUsesWith(UndefValue::get(F->getType()));
F->eraseFromParent();
InternalFns[u] = nullptr;
FoundDeadFn = true;
}
@ -5737,6 +5730,14 @@ ChangeStatus Attributor::run(Module &M) {
// Rewrite the functions as requested during manifest.
ManifestChange = ManifestChange | rewriteFunctionSignatures();
STATS_DECL(AAIsDead, Function, "Number of dead functions deleted.");
BUILD_STAT_NAME(AAIsDead, Function) += ToBeDeletedFunctions.size();
for (Function *Fn : ToBeDeletedFunctions) {
Fn->deleteBody();
Fn->replaceAllUsesWith(UndefValue::get(Fn->getType()));
Fn->eraseFromParent();
}
if (VerifyMaxFixpointIterations &&
IterationCounter != MaxFixpointIterations) {
errs() << "\n[Attributor] Fixpoint iteration done after: "