maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lldb][NFC] Always update m_cache_{hits/misses} in FormatCache 

Summary:
These two variables are only incremented under LLDB_CONFIGURATION_DEBUG but their
value is always logged when verbose lldb formatter logging is enabled, which causes that our
cache hit/miss log looks like this in non-Debug builds:

```
Cache hits: 0 - Cache Misses: 0
...
Cache hits: 0 - Cache Misses: 0
...
Cache hits: 0 - Cache Misses: 0
```

This just always increments those two counters independent of build mode.

Reviewers: JDevlieghere

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D76687
This commit is contained in:
Raphael Isemann 2020-03-24 20:16:41 +01:00
parent aef982e35a
commit 6b6a779ca8
2 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/include/lldb/DataFormatters/FormatCache.h
View File

@ -49,13 +49,13 @@ private:
CacheMap m_map; CacheMap m_map;
std::recursive_mutex m_mutex; std::recursive_mutex m_mutex;
uint64_t m_cache_hits; uint64_t m_cache_hits = 0;
uint64_t m_cache_misses; uint64_t m_cache_misses = 0;
Entry &GetEntry(ConstString type); Entry &GetEntry(ConstString type);
public: public:
FormatCache(); FormatCache() = default;
template <typename ImplSP> bool Get(ConstString type, ImplSP &format_impl_sp); template <typename ImplSP> bool Get(ConstString type, ImplSP &format_impl_sp);
void Set(ConstString type, lldb::TypeFormatImplSP &format_sp); void Set(ConstString type, lldb::TypeFormatImplSP &format_sp);

13
lldb/source/DataFormatters/FormatCache.cpp
View File

@ -51,15 +51,6 @@ void FormatCache::Entry::Set(lldb::SyntheticChildrenSP synthetic_sp) {
m_synthetic_sp = synthetic_sp; m_synthetic_sp = synthetic_sp;
} }
FormatCache::FormatCache()
: m_map(), m_mutex()
#ifdef LLDB_CONFIGURATION_DEBUG
,
m_cache_hits(0), m_cache_misses(0)
#endif
{
}
FormatCache::Entry &FormatCache::GetEntry(ConstString type) { FormatCache::Entry &FormatCache::GetEntry(ConstString type) {
auto i = m_map.find(type), e = m_map.end(); auto i = m_map.find(type), e = m_map.end();
if (i != e) if (i != e)
@ -87,15 +78,11 @@ bool FormatCache::Get(ConstString type, ImplSP &format_impl_sp) {
std::lock_guard<std::recursive_mutex> guard(m_mutex); std::lock_guard<std::recursive_mutex> guard(m_mutex);
auto entry = GetEntry(type); auto entry = GetEntry(type);
if (entry.IsCached<ImplSP>()) { if (entry.IsCached<ImplSP>()) {
#ifdef LLDB_CONFIGURATION_DEBUG
m_cache_hits++; m_cache_hits++;
#endif
entry.Get(format_impl_sp); entry.Get(format_impl_sp);
return true; return true;
} }
#ifdef LLDB_CONFIGURATION_DEBUG
m_cache_misses++; m_cache_misses++;
#endif
format_impl_sp.reset(); format_impl_sp.reset();
return false; return false;
} }