From 6aa91cf13d623d3f2cf13c468c85c8164a2ad413 Mon Sep 17 00:00:00 2001 From: Rui Ueyama Date: Thu, 3 Apr 2014 21:00:03 +0000 Subject: [PATCH] Early return. llvm-svn: 205567 --- lld/lib/Core/Resolver.cpp | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/lld/lib/Core/Resolver.cpp b/lld/lib/Core/Resolver.cpp index 6b0c217f9955..1361437c984a 100644 --- a/lld/lib/Core/Resolver.cpp +++ b/lld/lib/Core/Resolver.cpp @@ -69,6 +69,11 @@ private: } // namespace void Resolver::handleFile(const File &file) { + bool isEmpty = file.defined().empty() && file.sharedLibrary().empty() && + file.absolute().empty() && file.undefined().empty(); + if (isEmpty) + return; + for (const DefinedAtom *atom : file.defined()) doDefinedAtom(*atom); @@ -90,13 +95,10 @@ void Resolver::handleFile(const File &file) { for (const AbsoluteAtom *atom : file.absolute()) doAbsoluteAtom(*atom); - // If we make some progress on linking, notify that fact to the input file - // manager, because it may want to know that for --start-group/end-group. - bool progress = !file.defined().empty() || !file.sharedLibrary().empty() || - !file.absolute().empty() || !file.undefined().empty(); - if (progress) { - _context.inputGraph().notifyProgress(); - } + // Notify the input file manager of the fact that we have made some progress + // on linking using the current input file. It may want to know the fact for + // --start-group/--end-group. + _context.inputGraph().notifyProgress(); } void Resolver::forEachUndefines(UndefCallback callback,