maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang] NFC: Fix range-based for loop warnings related to decl lookup

This commit is contained in:
Jan Svoboda 2021-04-19 18:31:31 +02:00
parent 2aff4f7f57
commit 6a72ed239c
6 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/lib/CodeGen/CGBlocks.cpp
View File

@ -2887,7 +2887,7 @@ static void configureBlocksRuntimeObject(CodeGenModule &CGM,
"expected Function or GlobalVariable"); "expected Function or GlobalVariable");
const NamedDecl *ND = nullptr; const NamedDecl *ND = nullptr;
for (const auto &Result : DC->lookup(&II)) for (const auto *Result : DC->lookup(&II))
if ((ND = dyn_cast<FunctionDecl>(Result)) || if ((ND = dyn_cast<FunctionDecl>(Result)) ||
(ND = dyn_cast<VarDecl>(Result))) (ND = dyn_cast<VarDecl>(Result)))
break; break;

2
clang/lib/CodeGen/CGCUDANV.cpp
View File

@ -337,7 +337,7 @@ void CGNVCUDARuntime::emitDeviceStubBodyNew(CodeGenFunction &CGF,
IdentifierInfo &cudaLaunchKernelII = IdentifierInfo &cudaLaunchKernelII =
CGM.getContext().Idents.get(LaunchKernelName); CGM.getContext().Idents.get(LaunchKernelName);
FunctionDecl *cudaLaunchKernelFD = nullptr; FunctionDecl *cudaLaunchKernelFD = nullptr;
for (const auto &Result : DC->lookup(&cudaLaunchKernelII)) { for (auto *Result : DC->lookup(&cudaLaunchKernelII)) {
if (FunctionDecl *FD = dyn_cast<FunctionDecl>(Result)) if (FunctionDecl *FD = dyn_cast<FunctionDecl>(Result))
cudaLaunchKernelFD = FD; cudaLaunchKernelFD = FD;
} }

4
clang/lib/CodeGen/CGObjCGNU.cpp
View File

@ -1232,7 +1232,7 @@ class CGObjCGNUstep2 : public CGObjCGNUstep {
DeclContext *DC = TranslationUnitDecl::castToDeclContext(TUDecl); DeclContext *DC = TranslationUnitDecl::castToDeclContext(TUDecl);
const ObjCInterfaceDecl *OID = nullptr; const ObjCInterfaceDecl *OID = nullptr;
for (const auto &Result : DC->lookup(&II)) for (const auto *Result : DC->lookup(&II))
if ((OID = dyn_cast<ObjCInterfaceDecl>(Result))) if ((OID = dyn_cast<ObjCInterfaceDecl>(Result)))
break; break;
@ -2319,7 +2319,7 @@ llvm::Value *CGObjCGNU::EmitNSAutoreleasePoolClassRef(CodeGenFunction &CGF) {
DeclContext *DC = TranslationUnitDecl::castToDeclContext(TUDecl); DeclContext *DC = TranslationUnitDecl::castToDeclContext(TUDecl);
const VarDecl *VD = nullptr; const VarDecl *VD = nullptr;
for (const auto &Result : DC->lookup(&II)) for (const auto *Result : DC->lookup(&II))
if ((VD = dyn_cast<VarDecl>(Result))) if ((VD = dyn_cast<VarDecl>(Result)))
break; break;

2
clang/lib/CodeGen/CGObjCMac.cpp
View File

@ -6522,7 +6522,7 @@ static llvm::GlobalValue::DLLStorageClassTypes getStorage(CodeGenModule &CGM,
DeclContext *DC = TranslationUnitDecl::castToDeclContext(TUDecl); DeclContext *DC = TranslationUnitDecl::castToDeclContext(TUDecl);
const VarDecl *VD = nullptr; const VarDecl *VD = nullptr;
for (const auto &Result : DC->lookup(&II)) for (const auto *Result : DC->lookup(&II))
if ((VD = dyn_cast<VarDecl>(Result))) if ((VD = dyn_cast<VarDecl>(Result)))
break; break;

16
clang/lib/CodeGen/CodeGenModule.cpp
View File

@ -3644,8 +3644,8 @@ GetRuntimeFunctionDecl(ASTContext &C, StringRef Name) {
DeclContext *DC = TranslationUnitDecl::castToDeclContext(TUDecl); DeclContext *DC = TranslationUnitDecl::castToDeclContext(TUDecl);
IdentifierInfo &CII = C.Idents.get(Name); IdentifierInfo &CII = C.Idents.get(Name);
for (const auto &Result : DC->lookup(&CII)) for (const auto *Result : DC->lookup(&CII))
if (const auto FD = dyn_cast<FunctionDecl>(Result)) if (const auto *FD = dyn_cast<FunctionDecl>(Result))
return FD; return FD;
if (!C.getLangOpts().CPlusPlus) if (!C.getLangOpts().CPlusPlus)
@ -3659,15 +3659,15 @@ GetRuntimeFunctionDecl(ASTContext &C, StringRef Name) {
for (const auto &N : {"__cxxabiv1", "std"}) { for (const auto &N : {"__cxxabiv1", "std"}) {
IdentifierInfo &NS = C.Idents.get(N); IdentifierInfo &NS = C.Idents.get(N);
for (const auto &Result : DC->lookup(&NS)) { for (const auto *Result : DC->lookup(&NS)) {
NamespaceDecl *ND = dyn_cast<NamespaceDecl>(Result); const NamespaceDecl *ND = dyn_cast<NamespaceDecl>(Result);
if (auto LSD = dyn_cast<LinkageSpecDecl>(Result)) if (auto *LSD = dyn_cast<LinkageSpecDecl>(Result))
for (const auto &Result : LSD->lookup(&NS)) for (const auto *Result : LSD->lookup(&NS))
if ((ND = dyn_cast<NamespaceDecl>(Result))) if ((ND = dyn_cast<NamespaceDecl>(Result)))
break; break;
if (ND) if (ND)
for (const auto &Result : ND->lookup(&CXXII)) for (const auto *Result : ND->lookup(&CXXII))
if (const auto *FD = dyn_cast<FunctionDecl>(Result)) if (const auto *FD = dyn_cast<FunctionDecl>(Result))
return FD; return FD;
} }
@ -5038,7 +5038,7 @@ CodeGenModule::GetAddrOfConstantCFString(const StringLiteral *Literal) {
DeclContext *DC = TranslationUnitDecl::castToDeclContext(TUDecl); DeclContext *DC = TranslationUnitDecl::castToDeclContext(TUDecl);
const VarDecl *VD = nullptr; const VarDecl *VD = nullptr;
for (const auto &Result : DC->lookup(&II)) for (const auto *Result : DC->lookup(&II))
if ((VD = dyn_cast<VarDecl>(Result))) if ((VD = dyn_cast<VarDecl>(Result)))
break; break;

4
clang/lib/Sema/SemaCodeComplete.cpp
View File

@ -5257,7 +5257,7 @@ QualType getApproximateType(const Expr *E) {
Base = Base->getPointeeType(); // could handle unique_ptr etc here? Base = Base->getPointeeType(); // could handle unique_ptr etc here?
RecordDecl *RD = Base.isNull() ? nullptr : getAsRecordDecl(Base); RecordDecl *RD = Base.isNull() ? nullptr : getAsRecordDecl(Base);
if (RD && RD->isCompleteDefinition()) { if (RD && RD->isCompleteDefinition()) {
for (const auto &Member : RD->lookup(CDSME->getMember())) for (const auto *Member : RD->lookup(CDSME->getMember()))
if (const ValueDecl *VD = llvm::dyn_cast<ValueDecl>(Member)) if (const ValueDecl *VD = llvm::dyn_cast<ValueDecl>(Member))
return VD->getType().getNonReferenceType(); return VD->getType().getNonReferenceType();
} }
@ -5891,7 +5891,7 @@ static QualType getDesignatedType(QualType BaseType, const Designation &Desig) {
assert(D.isFieldDesignator()); assert(D.isFieldDesignator());
auto *RD = getAsRecordDecl(BaseType); auto *RD = getAsRecordDecl(BaseType);
if (RD && RD->isCompleteDefinition()) { if (RD && RD->isCompleteDefinition()) {
for (const auto &Member : RD->lookup(D.getField())) for (const auto *Member : RD->lookup(D.getField()))
if (const FieldDecl *FD = llvm::dyn_cast<FieldDecl>(Member)) { if (const FieldDecl *FD = llvm::dyn_cast<FieldDecl>(Member)) {
NextType = FD->getType(); NextType = FD->getType();
break; break;