From 69a10f466bcb2034f240558bd628f895cd345ffc Mon Sep 17 00:00:00 2001 From: Howard Hinnant Date: Wed, 1 Feb 2012 18:52:35 +0000 Subject: [PATCH] Removing a TODO: can_catch is fundamentally different than search_above_dst. can_catch is looking for an unamiguous public base class of a specific type, but at any address. search_above_dst is looking for an unambiguous public base class of a specific type, *and* at a specific address. Additionally can_catch is run for all types. search_above_dst is only run on class types. So these are only superficially similar. Not similar enough for resuse, at least without making the code unreadable. llvm-svn: 149522 --- libcxxabi/src/private_typeinfo.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/libcxxabi/src/private_typeinfo.cpp b/libcxxabi/src/private_typeinfo.cpp index a09deb58eed8..6cc2f64ea670 100644 --- a/libcxxabi/src/private_typeinfo.cpp +++ b/libcxxabi/src/private_typeinfo.cpp @@ -218,8 +218,6 @@ __pointer_to_member_type_info::display() const // // catch (...) : adjustedPtr == & of the exception -// TODO: can_catch looks similar to search_above_dst. Reuse? - bool __shim_type_info::can_catch(const __shim_type_info* thrown_type, void*&) const