maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Use LLVM's preferred current_path API instead of calling getcwd(3) directly. 

The existing code also failed to allocate a buffer for it so getcwd corrupted
the stack. sys::fs::current_path takes care of the memory management.

llvm-svn: 180669
This commit is contained in:
Benjamin Kramer 2013-04-27 08:12:29 +00:00
parent b33b6cb84a
commit 698d7c86f0
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
clang/lib/Driver/Tools.cpp
View File

@ -1775,9 +1775,6 @@ static bool shouldUseLeafFramePointer(const ArgList &Args,
return true;
}
// FIXME: This is a temporary hack until I can find a fix that works for all
// platforms.
#define MAXPATHLEN 4096
/// If the PWD environment variable is set, add a CC1 option to specify the
/// debug compilation directory.
static void addDebugCompDirArg(const ArgList &Args, ArgStringList &CmdArgs) {
@ -1794,9 +1791,10 @@ static void addDebugCompDirArg(const ArgList &Args, ArgStringList &CmdArgs) {
CmdArgs.push_back(Args.MakeArgString(pwd));
return;
}
// Fall back to using getcwd.
char *cwd;
if (pwd && ::getcwd(cwd, MAXPATHLEN)) {
SmallString<128> cwd;
if (!llvm::sys::fs::current_path(cwd)) {
CmdArgs.push_back("-fdebug-compilation-dir");
CmdArgs.push_back(Args.MakeArgString(cwd));
}