maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Revert "Validate argument passed to __builtin_frame_address and __builtin_return_address" 

This reverts commit c93112dc4f.
This commit is contained in:
zoecarver 2020-02-24 14:33:39 -08:00
parent cf9dae122e
commit 6980782572
2 changed files with 3 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang/lib/Sema/SemaChecking.cpp
View File

@ -1847,11 +1847,6 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID,
if (SemaBuiltinOSLogFormat(TheCall))
return ExprError();
break;
case Builtin::BI__builtin_frame_address:
case Builtin::BI__builtin_return_address:
if (!SemaBuiltinConstantArgRange(TheCall, 0, 0, 0xFFFF))
return ExprError();
break;
}
// Since the target specific builtins for each arch overlap, only check those

28
clang/test/Sema/builtin-stackaddress.c
View File

@ -1,6 +1,5 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s
void a(unsigned x) {
void* a(unsigned x) {
return __builtin_return_address(0);
}
@ -9,30 +8,9 @@ return __builtin_return_address(x); // expected-error{{argument to '__builtin_re
}
void* c(unsigned x) {
// expected-error@+1 {{argument value 4294967295 is outside the valid range [0, 65535]}}
return __builtin_return_address(-1);
}
void* d(unsigned x) {
// expected-error@+1 {{argument value 1048575 is outside the valid range [0, 65535]}}
return __builtin_return_address(0xFFFFF);
}
void* e(unsigned x) {
return __builtin_frame_address(0);
}
void f(unsigned x) {
// expected-error@+1 {{argument to '__builtin_frame_address' must be a constant integer}}
return __builtin_frame_address(x);
}
void* g(unsigned x) {
// expected-error@+1 {{argument value 4294967295 is outside the valid range [0, 65535]}}
return __builtin_frame_address(-1);
}
void* h(unsigned x) {
// expected-error@+1 {{argument value 1048575 is outside the valid range [0, 65535]}}
return __builtin_frame_address(0xFFFFF);
void d(unsigned x) {
return __builtin_frame_address(x); // expected-error{{argument to '__builtin_frame_address' must be a constant integer}}
}