maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

clang/darwin: Don't use response files with ld64 

This morally reverts D82777 -- turns out that ld64 crashes with many
response files, so we must stop passing them to it until the crash is
fixed.

Differential Revision: https://reviews.llvm.org/D92357
This commit is contained in:
Nico Weber 2020-11-30 20:10:30 -05:00
parent 2d539d7854
commit 68f2ff59d1
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang/lib/Driver/ToolChains/Darwin.cpp
View File

@ -698,7 +698,10 @@ void darwin::Linker::ConstructJob(Compilation &C, const JobAction &JA,
} }
ResponseFileSupport ResponseSupport; ResponseFileSupport ResponseSupport;
if (Version[0] >= 607 || LinkerIsLLDDarwinNew) { if (LinkerIsLLDDarwinNew) {
// Xcode12's ld64 added support for @response files, but it's crashy:
// https://openradar.appspot.com/radar?id=4933317065441280
// FIXME: Pass this for ld64 once it no longer crashes.
ResponseSupport = ResponseFileSupport::AtFileUTF8(); ResponseSupport = ResponseFileSupport::AtFileUTF8();
} else { } else {
// For older versions of the linker, use the legacy filelist method instead. // For older versions of the linker, use the legacy filelist method instead.