From 67dace890fa35ea66557825472ca1a61bc7f938e Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Tue, 3 Feb 2009 06:17:37 +0000 Subject: [PATCH] Add ABIArgInfo::Direct kind, which passes arguments using whatever the native IRgen type is. This is like Default, but without any extra semantics (like automatic tweaking of structures or void). llvm-svn: 63615 --- clang/lib/CodeGen/ABIInfo.h | 8 ++++++++ clang/lib/CodeGen/CGCall.cpp | 19 ++++++++++++++++++- 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/clang/lib/CodeGen/ABIInfo.h b/clang/lib/CodeGen/ABIInfo.h index e0917f77e0e4..d343ffdbbe6d 100644 --- a/clang/lib/CodeGen/ABIInfo.h +++ b/clang/lib/CodeGen/ABIInfo.h @@ -27,6 +27,10 @@ namespace clang { public: enum Kind { Default, + + Direct, /// Pass the argument directly using the normal + /// converted LLVM type. + StructRet, /// Only valid for return values. The return value /// should be passed through a pointer to a caller /// allocated location passed as an implicit first @@ -68,6 +72,9 @@ namespace clang { static ABIArgInfo getDefault() { return ABIArgInfo(Default); } + static ABIArgInfo getDirect() { + return ABIArgInfo(Direct); + } static ABIArgInfo getStructRet() { return ABIArgInfo(StructRet); } @@ -86,6 +93,7 @@ namespace clang { Kind getKind() const { return TheKind; } bool isDefault() const { return TheKind == Default; } + bool isDirect() const { return TheKind == Direct; } bool isStructRet() const { return TheKind == StructRet; } bool isIgnore() const { return TheKind == Ignore; } bool isCoerce() const { return TheKind == Coerce; } diff --git a/clang/lib/CodeGen/CGCall.cpp b/clang/lib/CodeGen/CGCall.cpp index 44105eb4425e..b040b7ff86e2 100644 --- a/clang/lib/CodeGen/CGCall.cpp +++ b/clang/lib/CodeGen/CGCall.cpp @@ -897,6 +897,10 @@ CodeGenTypes::GetFunctionType(const CGFunctionInfo &FI, bool IsVariadic) { } break; + case ABIArgInfo::Direct: + ResultType = ConvertType(RetTy); + break; + case ABIArgInfo::StructRet: { ResultType = llvm::Type::VoidTy; const llvm::Type *STy = ConvertType(RetTy); @@ -933,6 +937,7 @@ CodeGenTypes::GetFunctionType(const CGFunctionInfo &FI, bool IsVariadic) { break; case ABIArgInfo::Default: + case ABIArgInfo::Direct: ArgTys.push_back(Ty); break; @@ -967,6 +972,7 @@ void CodeGenModule::ConstructAttributeList(const CGFunctionInfo &FI, const ABIArgInfo &RetAI = FI.getReturnInfo(); switch (RetAI.getKind()) { case ABIArgInfo::Default: + case ABIArgInfo::Direct: if (RetTy->isPromotableIntegerType()) { if (RetTy->isSignedIntegerType()) { RetAttrs |= llvm::Attribute::SExt; @@ -1011,6 +1017,7 @@ void CodeGenModule::ConstructAttributeList(const CGFunctionInfo &FI, break; case ABIArgInfo::Default: + case ABIArgInfo::Direct: if (ParamType->isPromotableIntegerType()) { if (ParamType->isSignedIntegerType()) { Attributes |= llvm::Attribute::SExt; @@ -1068,7 +1075,8 @@ void CodeGenFunction::EmitFunctionProlog(const CGFunctionInfo &FI, switch (ArgI.getKind()) { case ABIArgInfo::ByVal: - case ABIArgInfo::Default: { + case ABIArgInfo::Default: + case ABIArgInfo::Direct: { assert(AI != Fn->arg_end() && "Argument mismatch!"); llvm::Value* V = AI; if (!getContext().typesAreCompatible(Ty, Arg->getType())) { @@ -1136,6 +1144,7 @@ void CodeGenFunction::EmitFunctionEpilog(const CGFunctionInfo &FI, break; case ABIArgInfo::Default: + case ABIArgInfo::Direct: RV = Builder.CreateLoad(ReturnValue); break; @@ -1178,6 +1187,7 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo, break; case ABIArgInfo::Default: + case ABIArgInfo::Direct: case ABIArgInfo::Ignore: case ABIArgInfo::Coerce: break; @@ -1196,6 +1206,7 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo, switch (ArgInfo.getKind()) { case ABIArgInfo::ByVal: // Default is byval case ABIArgInfo::Default: + case ABIArgInfo::Direct: if (RV.isScalar()) { Args.push_back(RV.getScalarVal()); } else if (RV.isComplex()) { @@ -1245,6 +1256,12 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo, case ABIArgInfo::Default: return RValue::get(RetTy->isVoidType() ? 0 : CI); + + case ABIArgInfo::Direct: + assert((!RetTy->isAnyComplexType() && + CodeGenFunction::hasAggregateLLVMType(RetTy)) && + "FIXME: Implemented return for non-scalar direct types."); + return RValue::get(CI); case ABIArgInfo::Ignore: if (RetTy->isVoidType())