maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

c: make __attribute__((unused)) transitive. 

Don't warn if annotated decl is used inside another
   unused. // rdar://12233989

llvm-svn: 163329
This commit is contained in:
Fariborz Jahanian 2012-09-06 16:43:18 +00:00
parent 83859e7728
commit 66c93f443d
2 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
clang/lib/Sema/SemaExpr.cpp
View File

@ -66,6 +66,18 @@ bool Sema::CanUseDecl(NamedDecl *D) {
return true; return true;
} }
static void DiagnoseUnusedOfDecl(Sema &S, NamedDecl *D, SourceLocation Loc) {
// Warn if this is used but marked unused.
if (D->hasAttr<UnusedAttr>()) {
const Decl *DC = cast<Decl>(S.getCurLexicalContext());
// A category implicitly has the availability of the interface.
if (const ObjCCategoryDecl *CatD = dyn_cast<ObjCCategoryDecl>(DC))
DC = CatD->getClassInterface();
if (!DC->hasAttr<UnusedAttr>())
S.Diag(Loc, diag::warn_used_but_marked_unused) << D->getDeclName();
}
}
static AvailabilityResult DiagnoseAvailabilityOfDecl(Sema &S, static AvailabilityResult DiagnoseAvailabilityOfDecl(Sema &S,
NamedDecl *D, SourceLocation Loc, NamedDecl *D, SourceLocation Loc,
const ObjCInterfaceDecl *UnknownObjCClass) { const ObjCInterfaceDecl *UnknownObjCClass) {
@ -250,9 +262,7 @@ bool Sema::DiagnoseUseOfDecl(NamedDecl *D, SourceLocation Loc,
} }
DiagnoseAvailabilityOfDecl(*this, D, Loc, UnknownObjCClass); DiagnoseAvailabilityOfDecl(*this, D, Loc, UnknownObjCClass);
// Warn if this is used but marked unused. DiagnoseUnusedOfDecl(*this, D, Loc);
if (D->hasAttr<UnusedAttr>())
Diag(Loc, diag::warn_used_but_marked_unused) << D->getDeclName();
diagnoseUseOfInternalDeclInInlineFunction(*this, D, Loc); diagnoseUseOfInternalDeclInInlineFunction(*this, D, Loc);

14
clang/test/Sema/warn-unused-function.c
View File

@ -1,4 +1,4 @@
// RUN: %clang_cc1 -fsyntax-only -Wunused-function -Wunneeded-internal-declaration -verify %s // RUN: %clang_cc1 -fsyntax-only -Wused-but-marked-unused -Wunused-function -Wunneeded-internal-declaration -verify %s
// RUN: %clang_cc1 -fsyntax-only -verify -Wunused %s // RUN: %clang_cc1 -fsyntax-only -verify -Wunused %s
// RUN: %clang_cc1 -fsyntax-only -verify -Wall %s // RUN: %clang_cc1 -fsyntax-only -verify -Wall %s
@ -54,3 +54,15 @@ void f13(void) {
char * const __attribute__((cleanup(cleanupMalloc))) a; char * const __attribute__((cleanup(cleanupMalloc))) a;
(void)a; (void)a;
} }
// rdar://12233989
extern void a(void) __attribute__((unused));
extern void b(void) __attribute__((unused));
void b(void)
{
}
void a(void)
{
b();
}