maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Verifier] Allow TBAA metadata on atomicrmw and atomiccmpxchg 

This used to be allowed before r289402 by default (before r289402 you
could have TBAA metadata on any instruction), and while I'm not sure
that it helps, it does sound reasonable enough to not fail the verifier
and we have out-of-tree users who use this.

llvm-svn: 289872
This commit is contained in:
Sanjoy Das 2016-12-15 21:23:44 +00:00
parent 0c3f57b133
commit 6698c15cb6
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/lib/IR/Verifier.cpp
View File

@ -4062,7 +4062,8 @@ void Verifier::visitInstruction(Instruction &I) {
if (MDNode *TBAA = I.getMetadata(LLVMContext::MD_tbaa)) {
Assert(isa<LoadInst>(I) || isa<StoreInst>(I) || isa<CallInst>(I) ||
isa<VAArgInst>(I),
isa<VAArgInst>(I) || isa<AtomicRMWInst>(I) ||
isa<AtomicCmpXchgInst>(I),
"TBAA is only for loads, stores and calls!", &I);
visitTBAAMetadata(I, TBAA);
}

22
llvm/test/Verifier/tbaa-allowed.ll Normal file
View File

@ -0,0 +1,22 @@
; RUN: opt -S < %s
; This file contains TBAA metadata that is okay and should pass the verifier.
declare void @callee()
declare void @llvm.va_start(i8*) nounwind
define void @f_0(i8* %ptr, ...) {
%args = alloca i8, align 8
call void @llvm.va_start(i8* %args)
%old = atomicrmw add i8* %ptr, i8 0 seq_cst, !tbaa !{!1, !1, i64 0}
%pair = cmpxchg i8* %ptr, i8 0, i8 1 acquire acquire, !tbaa !{!1, !1, i64 0}
%ld = load i8, i8* %ptr, !tbaa !{!1, !1, i64 0}
store i8 1, i8* %ptr, !tbaa !{!1, !1, i64 0}
call void @callee(), !tbaa !{!1, !1, i64 0}
%argval = va_arg i8* %args, i8, !tbaa !{!1, !1, i64 0}
ret void
}
!0 = !{!"root"}
!1 = !{!"scalar-a", !0}