maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[ORC][C-bindings] Fix some ORC C bindings function names and signatures. 

LLVMOrcDisposeObjectLayer and LLVMOrcExecutionSessionGetJITDylibByName did not
have matching signatures between the C-API header and binding implementations.
Fixes http://llvm.org/PR49745.

Patch by Mats Larsen. Thanks Mats!

Reviewed by: lhames

Differential Revision: https://reviews.llvm.org/D99478
This commit is contained in:
Lang Hames 2021-03-28 16:30:47 -07:00
parent 5a79909a14
commit 666df2e2cb
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/include/llvm-c/Orc.h
View File

@ -339,8 +339,7 @@ LLVMErrorRef LLVMOrcResourceTrackerRemove(LLVMOrcResourceTrackerRef RT);
* ownership has not been passed to a JITDylib (e.g. because some error * ownership has not been passed to a JITDylib (e.g. because some error
* prevented the client from calling LLVMOrcJITDylibAddGenerator). * prevented the client from calling LLVMOrcJITDylibAddGenerator).
*/ */
void LLVMOrcDisposeDefinitionGenerator( void LLVMOrcDisposeDefinitionGenerator(LLVMOrcDefinitionGeneratorRef DG);
LLVMOrcDefinitionGeneratorRef DG);
/** /**
* Dispose of a MaterializationUnit. * Dispose of a MaterializationUnit.
@ -388,7 +387,9 @@ LLVMOrcExecutionSessionCreateJITDylib(LLVMOrcExecutionSessionRef ES,
* Returns the JITDylib with the given name, or NULL if no such JITDylib * Returns the JITDylib with the given name, or NULL if no such JITDylib
* exists. * exists.
*/ */
LLVMOrcJITDylibRef LLVMOrcExecutionSessionGetJITDylibByName(const char *Name); LLVMOrcJITDylibRef
LLVMOrcExecutionSessionGetJITDylibByName(LLVMOrcExecutionSessionRef ES,
const char *Name);
/** /**
* Return a reference to a newly created resource tracker associated with JD. * Return a reference to a newly created resource tracker associated with JD.

2
llvm/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp
View File

@ -393,7 +393,7 @@ void LLVMOrcDisposeJITTargetMachineBuilder(
delete unwrap(JTMB); delete unwrap(JTMB);
} }
void lLVMOrcDisposeObjectLayer(LLVMOrcObjectLayerRef ObjLayer) { void LLVMOrcDisposeObjectLayer(LLVMOrcObjectLayerRef ObjLayer) {
delete unwrap(ObjLayer); delete unwrap(ObjLayer);
} }