maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[TLI checker] Update for post-commit review comments 

Ignore undefined symbols; other minor code cleanup.
Replace test objects and their asm source with a yaml equivalent.

Differential Revision: https://reviews.llvm.org/D114478
This commit is contained in:
Paul Robinson 2021-11-23 10:24:29 -08:00
parent 5fe151f98f
commit 66071f440c
5 changed files with 1040 additions and 326 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
llvm/test/tools/llvm-tli-checker/Inputs/ps4-tli-check.right.so
View File

Binary file not shown.

BIN
llvm/test/tools/llvm-tli-checker/Inputs/ps4-tli-check.wrong.so
View File

Binary file not shown.

291
llvm/test/tools/llvm-tli-checker/ps4-tli-check.s
View File

@ -1,291 +0,0 @@
# REQUIRES: x86-registered-target
#
## The object files ps4-tli-checks.right.so and ps4-tli-checks.wrong.so
## were generated with the following commands:
## llvm-mc --triple=x86_64-scei-ps4 --filetype=obj ps4-tli-check.s -o t.o
## ld.lld --shared t.o -o Inputs/ps4-tli-check.right.so
## llvm-mc --triple=x86_64-scei-ps4 --defsym WRONG=1 --filetype=obj ps4-tli-check.s -o t2.o
## ld.lld --shared t2.o -o Inputs/ps4-tli-check.wrong.so
#
# RUN: llvm-tli-checker --triple=x86_64-scei-ps4 %S/Inputs/ps4-tli-check.right.so | FileCheck %s
#
# RUN: echo %S/Inputs/ps4-tli-check.wrong.so > %t2.txt
# RUN: llvm-tli-checker --triple x86_64-scei-ps4 @%t2.txt | \
# RUN: FileCheck %s --check-prefix=WRONG_SUMMARY --check-prefix=WRONG_DETAIL \
# RUN: --implicit-check-not="==" --implicit-check-not="<<" --implicit-check-not=">>"
# RUN: llvm-tli-checker --triple x86_64-scei-ps4 @%t2.txt --report=summary | \
# RUN: FileCheck %s --check-prefix=WRONG_SUMMARY \
# RUN: --implicit-check-not="==" --implicit-check-not="<<" --implicit-check-not=">>"
## --separate implies --report=summary.
# RUN: llvm-tli-checker --triple x86_64-scei-ps4 @%t2.txt --separate | \
# RUN: FileCheck %s --check-prefix=WRONG_SUMMARY \
# RUN: --implicit-check-not="==" --implicit-check-not="<<" --implicit-check-not=">>"
#
# RUN: llvm-tli-checker --triple x86_64-scei-ps4 --dump-tli > %t3.txt
# RUN: FileCheck %s --check-prefix=AVAIL --input-file %t3.txt
# RUN: FileCheck %s --check-prefix=UNAVAIL --input-file %t3.txt
#
# CHECK: << Total TLI yes SDK no: 0
# CHECK: >> Total TLI no SDK yes: 0
# CHECK: == Total TLI yes SDK yes: 235
#
# WRONG_DETAIL: << TLI yes SDK no : '_ZdaPv'
# WRONG_DETAIL: >> TLI no SDK yes: '_ZdaPvj'
# WRONG_SUMMARY: << Total TLI yes SDK no: 1{{$}}
# WRONG_SUMMARY: >> Total TLI no SDK yes: 1{{$}}
# WRONG_SUMMARY: == Total TLI yes SDK yes: 234
#
## The -COUNT suffix doesn't care if there are too many matches, so check
## the exact count first; the two directives should add up to that.
# AVAIL: TLI knows 466 symbols, 235 available
# AVAIL-COUNT-235: {{^}} available
# UNAVAIL-COUNT-231: not available
.macro defname name
.globl \name
.type \name ,@function
\name : nop
.endm
.text
# For the WRONG case, omit _ZdaPv and include _ZdaPvj.
.ifdef WRONG
defname _ZdaPvj
.else
defname _ZdaPv
.endif
defname _ZdaPvRKSt9nothrow_t
defname _ZdaPvSt11align_val_t
defname _ZdaPvSt11align_val_tRKSt9nothrow_t
defname _ZdaPvm
defname _ZdaPvmSt11align_val_t
defname _ZdlPv
defname _ZdlPvRKSt9nothrow_t
defname _ZdlPvSt11align_val_t
defname _ZdlPvSt11align_val_tRKSt9nothrow_t
defname _ZdlPvm
defname _ZdlPvmSt11align_val_t
defname _Znam
defname _ZnamRKSt9nothrow_t
defname _ZnamSt11align_val_t
defname _ZnamSt11align_val_tRKSt9nothrow_t
defname _Znwm
defname _ZnwmRKSt9nothrow_t
defname _ZnwmSt11align_val_t
defname _ZnwmSt11align_val_tRKSt9nothrow_t
defname __cxa_atexit
defname __cxa_guard_abort
defname __cxa_guard_acquire
defname __cxa_guard_release
defname abs
defname acos
defname acosf
defname acosh
defname acoshf
defname acoshl
defname acosl
defname aligned_alloc
defname asin
defname asinf
defname asinh
defname asinhf
defname asinhl
defname asinl
defname atan
defname atan2
defname atan2f
defname atan2l
defname atanf
defname atanh
defname atanhf
defname atanhl
defname atanl
defname atof
defname atoi
defname atol
defname atoll
defname calloc
defname cbrt
defname cbrtf
defname cbrtl
defname ceil
defname ceilf
defname ceill
defname clearerr
defname copysign
defname copysignf
defname copysignl
defname cos
defname cosf
defname cosh
defname coshf
defname coshl
defname cosl
defname exp
defname exp2
defname exp2f
defname exp2l
defname expf
defname expl
defname expm1
defname expm1f
defname expm1l
defname fabs
defname fabsf
defname fabsl
defname fclose
defname fdopen
defname feof
defname ferror
defname fflush
defname fgetc
defname fgetpos
defname fgets
defname fileno
defname floor
defname floorf
defname floorl
defname fmax
defname fmaxf
defname fmaxl
defname fmin
defname fminf
defname fminl
defname fmod
defname fmodf
defname fmodl
defname fopen
defname fprintf
defname fputc
defname fputs
defname fread
defname free
defname frexp
defname frexpf
defname frexpl
defname fscanf
defname fseek
defname fsetpos
defname ftell
defname fwrite
defname getc
defname getchar
defname gets
defname isdigit
defname labs
defname ldexp
defname ldexpf
defname ldexpl
defname llabs
defname log
defname log10
defname log10f
defname log10l
defname log1p
defname log1pf
defname log1pl
defname log2
defname log2f
defname log2l
defname logb
defname logbf
defname logbl
defname logf
defname logl
defname malloc
defname memalign
defname memchr
defname memcmp
defname memcpy
defname memmove
defname memset
defname mktime
defname modf
defname modff
defname modfl
defname nearbyint
defname nearbyintf
defname nearbyintl
defname perror
defname posix_memalign
defname pow
defname powf
defname powl
defname printf
defname putc
defname putchar
defname puts
defname qsort
defname realloc
defname remainder
defname remainderf
defname remainderl
defname remove
defname rewind
defname rint
defname rintf
defname rintl
defname round
defname roundf
defname roundl
defname scanf
defname setbuf
defname setvbuf
defname sin
defname sinf
defname sinh
defname sinhf
defname sinhl
defname sinl
defname snprintf
defname sprintf
defname sqrt
defname sqrtf
defname sqrtl
defname sscanf
defname strcasecmp
defname strcat
defname strchr
defname strcmp
defname strcoll
defname strcpy
defname strcspn
defname strdup
defname strlen
defname strncasecmp
defname strncat
defname strncmp
defname strncpy
defname strpbrk
defname strrchr
defname strspn
defname strstr
defname strtod
defname strtof
defname strtok
defname strtok_r
defname strtol
defname strtold
defname strtoll
defname strtoul
defname strtoull
defname strxfrm
defname tan
defname tanf
defname tanh
defname tanhf
defname tanhl
defname tanl
defname trunc
defname truncf
defname truncl
defname ungetc
defname vfprintf
defname vfscanf
defname vprintf
defname vscanf
defname vsnprintf
defname vsprintf
defname vsscanf
defname wcslen

1004
llvm/test/tools/llvm-tli-checker/ps4-tli-check.yaml Normal file
View File

File diff suppressed because it is too large Load Diff

71
llvm/tools/llvm-tli-checker/llvm-tli-checker.cpp
View File

@ -39,7 +39,7 @@ enum ID {
#include "Opts.inc"
#undef PREFIX
const opt::OptTable::Info InfoTable[] = {
static const opt::OptTable::Info InfoTable[] = {
#define OPTION(PREFIX, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM, \
HELPTEXT, METAVAR, VALUES) \
{ \
@ -55,7 +55,7 @@ class TLICheckerOptTable : public opt::OptTable {
public:
TLICheckerOptTable() : OptTable(InfoTable) {}
};
} // namespace
} // end anonymous namespace
// We have three levels of reporting.
enum class ReportKind {
@ -66,13 +66,14 @@ enum class ReportKind {
};
// Most of the ObjectFile interfaces return an Expected<T>, so make it easy
// to ignore those.
template <typename T> T unwrapIgnoreError(Expected<T> E) {
// to ignore errors.
template <typename T>
static T unwrapIgnoreError(Expected<T> E, T Default = T()) {
if (E)
return std::move(*E);
// Sink the error and return a nothing value.
consumeError(E.takeError());
return T();
return Default;
}
static void fail(const Twine &Message) {
@ -99,13 +100,14 @@ static void reportArchiveChildIssue(const object::Archive::Child &C, int Index,
}
// Return Name, and if Name is mangled, append "aka" and the demangled name.
static std::string PrintableName(StringRef Name) {
static std::string getPrintableName(StringRef Name) {
std::string OutputName = "'";
OutputName += Name;
OutputName += "'";
if (Name.startswith("_Z") || Name.startswith("??")) {
std::string DemangledName(demangle(Name.str()));
if (Name != DemangledName) {
OutputName += " aka ";
OutputName += demangle(Name.str());
OutputName += DemangledName;
}
return OutputName;
}
@ -119,7 +121,7 @@ struct TLINameList : std::vector<std::pair<StringRef, bool>> {
// Print out what we found.
void dump();
};
TLINameList TLINames;
static TLINameList TLINames;
void TLINameList::initialize(StringRef TargetTriple) {
Triple T(TargetTriple);
@ -146,7 +148,7 @@ void TLINameList::dump() {
// output as a header. So, for example, no need to repeat the triple.
for (auto &TLIName : TLINames) {
outs() << (TLIName.second ? " " : "not ")
<< "available: " << PrintableName(TLIName.first) << '\n';
<< "available: " << getPrintableName(TLIName.first) << '\n';
}
}
@ -159,24 +161,27 @@ class SDKNameMap : public StringMap<bool> {
public:
void populateFromFile(StringRef LibDir, StringRef LibName);
};
SDKNameMap SDKNames;
static SDKNameMap SDKNames;
// Given an ObjectFile, extract the global function symbols.
void SDKNameMap::populateFromObject(ObjectFile *O) {
// FIXME: Support COFF.
// FIXME: Support other formats.
if (!O->isELF()) {
WithColor::warning() << "Only ELF-format files are supported\n";
WithColor::warning() << O->getFileName()
<< ": only ELF-format files are supported\n";
return;
}
auto *ELF = cast<const ELFObjectFileBase>(O);
const auto *ELF = cast<ELFObjectFileBase>(O);
for (auto I = ELF->getDynamicSymbolIterators().begin();
I != ELF->getDynamicSymbolIterators().end(); ++I) {
// We want only global function symbols.
SymbolRef::Type Type = unwrapIgnoreError(I->getType());
uint32_t Flags = unwrapIgnoreError(I->getFlags());
StringRef Name = unwrapIgnoreError(I->getName());
if (Type == SymbolRef::ST_Function && (Flags & SymbolRef::SF_Global))
for (auto &S : ELF->getDynamicSymbolIterators()) {
// We want only defined global function symbols.
SymbolRef::Type Type = unwrapIgnoreError(S.getType());
uint32_t Flags = unwrapIgnoreError(S.getFlags());
section_iterator Section = unwrapIgnoreError(S.getSection(),
/*Default=*/O->section_end());
StringRef Name = unwrapIgnoreError(S.getName());
if (Type == SymbolRef::ST_Function && (Flags & SymbolRef::SF_Global) &&
Section != O->section_end())
insert({Name, true});
}
}
@ -211,7 +216,7 @@ void SDKNameMap::populateFromFile(StringRef LibDir, StringRef LibName) {
SmallString<255> Filepath(LibDir);
sys::path::append(Filepath, LibName);
if (!sys::fs::exists(Filepath)) {
WithColor::warning() << "Could not find '" << StringRef(Filepath) << "'\n";
WithColor::warning() << StringRef(Filepath) << ": not found\n";
return;
}
outs() << "\nLooking for symbols in '" << StringRef(Filepath) << "'\n";
@ -229,13 +234,12 @@ void SDKNameMap::populateFromFile(StringRef LibDir, StringRef LibName) {
else if (ObjectFile *O = dyn_cast<ObjectFile>(&Binary))
populateFromObject(O);
else {
WithColor::warning() << "Not an Archive or ObjectFile: '"
<< StringRef(Filepath) << "'\n";
WithColor::warning() << StringRef(Filepath)
<< ": not an archive or object file\n";
return;
}
if (Precount == size())
WithColor::warning() << "No symbols found in '" << StringRef(Filepath)
<< "'\n";
WithColor::warning() << StringRef(Filepath) << ": no symbols found\n";
else
outs() << "Found " << size() - Precount << " global function symbols in '"
<< StringRef(Filepath) << "'\n";
@ -268,10 +272,8 @@ int main(int argc, char *argv[]) {
}
std::vector<std::string> LibList = Args.getAllArgValues(OPT_INPUT);
if (LibList.empty()) {
WithColor::error() << "No input files\n";
exit(EXIT_FAILURE);
}
if (LibList.empty())
fail("no input files\n");
StringRef LibDir = Args.getLastArgValue(OPT_libdir_EQ);
bool SeparateMode = Args.hasArg(OPT_separate);
@ -283,10 +285,8 @@ int main(int argc, char *argv[]) {
.Case("discrepancy", ReportKind::Discrepancy)
.Case("full", ReportKind::Full)
.Default(ReportKind::Error);
if (ReportLevel == ReportKind::Error) {
WithColor::error() << "invalid option for --report: " << A->getValue();
exit(EXIT_FAILURE);
}
if (ReportLevel == ReportKind::Error)
fail(Twine("invalid option for --report: ", StringRef(A->getValue())));
}
for (size_t I = 0; I < LibList.size(); ++I) {
@ -330,7 +330,8 @@ int main(int argc, char *argv[]) {
constexpr char YesNo[2][4] = {"no ", "yes"};
constexpr char Indicator[4][3] = {"!!", ">>", "<<", "=="};
outs() << Indicator[Which] << " TLI " << YesNo[TLIHas] << " SDK "
<< YesNo[SDKHas] << ": " << PrintableName(TLIName.first) << '\n';
<< YesNo[SDKHas] << ": " << getPrintableName(TLIName.first)
<< '\n';
}
}